Skip to content

Clean up JSON #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Dec 26, 2025
+0 −9
Merged

Clean up JSON #2318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions inputfiles/addedTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,10 +603,6 @@
}
}
},
"dictionaries": {
Copy link
Collaborator

@saschanaz saschanaz Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is obvious...

"dictionary": {
}
},
"typedefs": {
"typedef": [
{
Expand Down
5 changes: 0 additions & 5 deletions inputfiles/removedTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,10 +309,5 @@
}
}
}
},
"typedefs": {
"typedef": [
"ArrayBufferView"
Copy link
Collaborator

@saschanaz saschanaz Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why is this okay?

ArrayBufferView is referenced by BufferSource that we use, so technically this is needed. But somehow we have been using it after removing it...

That's done by #405 by me 7 years ago, I need to recall what I was thinking about.

Copy link
Collaborator

@saschanaz saschanaz Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhh because arrayBufferViewTypes has ABV so it's okay even if it's not in IDL provided types. But then why is it okay to not remove it? Hmmmmm.

Copy link
Collaborator

@saschanaz saschanaz Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh because followTypeReferences explicitly ignores anything covered by baseTypeConversionMap, so even if we have ABV we ignore it because it's part of base types.

]
}
}