discrete pluralizer for lib.esnext.temporal unit unions#63190
Merged
jakebailey merged 2 commits intomicrosoft:mainfrom Feb 25, 2026
Merged
discrete pluralizer for lib.esnext.temporal unit unions#63190jakebailey merged 2 commits intomicrosoft:mainfrom
jakebailey merged 2 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
jakebailey
approved these changes
Feb 24, 2026
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Can you point to the type that this is becoming compatible with?
Seems fine, but want to understand.
Contributor
Author
|
Member
|
Ah, but the mapped type doesn't exist? |
Contributor
Author
|
Not in that specific form; they've used a |
Member
|
In a way I wish it were just |
Contributor
Author
|
Comme ça ? |
jakebailey
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For improved interoperability, makes
DateUnitandTimeUnitequivalent to their js-temporal counterparts by restricting the unions to singular nouns and using a pluralizer helper where applicable.