Redesign WSLA Session management #14067

OneBlue · 2026-01-15T01:43:22Z

Summary of the Pull Request

This change redesigns our per user session management logic into a global SessionManager.

This allows sessions to be interacted across Windows users.

PR Checklist

Closes: Link to issue #xxx
Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
Tests: Added/updated if needed and all pass
Localization: All end user facing strings can be localized
Dev docs: Added/updated if needed
Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

…oneblue/session-manager

Copilot

Pull request overview

This PR redesigns WSLA session management from a per-user session model to a global SessionManager. The change enables sessions to be accessed across Windows users with proper access control, replacing WSLAUserSession with WSLASessionManager throughout the codebase.

Changes:

Replaced per-user WSLAUserSession with global WSLASessionManager for centralized session management
Added access control logic to prevent non-elevated tokens from accessing elevated sessions
Introduced COMImplClass helper template to standardize COM-to-implementation forwarding
Updated GetNonElevatedToken to accept a TOKEN_TYPE parameter for flexible token generation

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`src/windows/wslaservice/inc/wslaservice.idl`	Renamed `IWSLAUserSession` to `IWSLASessionManager`, added `GetId()` method to `IWSLASession`, and added `Sid` field to session information
`src/windows/wslaservice/exe/WSLASessionManager.h/.cpp`	New global session manager implementation with token-based access control
`src/windows/wslaservice/exe/WSLASessionManagerFactory.h/.cpp`	Factory for singleton session manager instance
`src/windows/wslaservice/exe/WSLASession.h/.cpp`	Added session creator tracking (PID, SID, elevation status)
`src/windows/wslaservice/exe/COMImplClass.h`	New helper template for COM-to-implementation forwarding pattern
`src/windows/wslaservice/exe/WSLAContainer.h/.cpp`	Refactored to use `COMImplClass` base template
`test/windows/Common.h/.cpp`	Updated `GetNonElevatedToken` to accept `TOKEN_TYPE` parameter
`test/windows/WSLATests.cpp`	Updated tests for new session manager API and added elevation access control tests
`src/windows/common/WslClient.cpp`	Updated to use `IWSLASessionManager`
`src/windows/wsladiag/wsladiag.cpp`	Updated to use `IWSLASessionManager`

test/windows/Common.cpp

src/windows/wslaservice/exe/COMImplClass.h

src/windows/wslaservice/exe/WSLASessionManager.cpp

Copilot · 2026-01-16T02:21:44Z

test/windows/WSLATests.cpp

    {
-        wil::com_ptr<IWSLAUserSession> userSession;
-        VERIFY_SUCCEEDED(CoCreateInstance(__uuidof(WSLAUserSession), nullptr, CLSCTX_LOCAL_SERVER, IID_PPV_ARGS(&userSession)));
+        wil::com_ptr<IWSLASessionManager> userSession;


The variable is named userSession but now represents a global session manager, not a per-user session. Rename to manager or sessionManager for clarity and consistency with the rest of the test.

Copilot · 2026-01-16T02:21:44Z

test/windows/WSLATests.cpp

    {
-        wil::com_ptr<IWSLAUserSession> userSession;
-        VERIFY_SUCCEEDED(CoCreateInstance(__uuidof(WSLAUserSession), nullptr, CLSCTX_LOCAL_SERVER, IID_PPV_ARGS(&userSession)));
+        wil::com_ptr<IWSLASessionManager> userSession;


The variable is named userSession but now represents a global session manager, not a per-user session. Rename to manager or sessionManager for clarity and consistency with the rest of the test.

Copilot · 2026-01-16T02:21:44Z

test/windows/WSLATests.cpp


-        wil::com_ptr<IWSLAUserSession> userSession;
-        VERIFY_SUCCEEDED(CoCreateInstance(__uuidof(WSLAUserSession), nullptr, CLSCTX_LOCAL_SERVER, IID_PPV_ARGS(&userSession)));
+        wil::com_ptr<IWSLASessionManager> userSession;


The variable is named userSession but now represents a global session manager, not a per-user session. Rename to manager or sessionManager for clarity and consistency with the test at line 2361.

Copilot · 2026-01-16T02:21:44Z

test/windows/WSLATests.cpp


-        wil::com_ptr<IWSLAUserSession> userSession;
-        VERIFY_SUCCEEDED(CoCreateInstance(__uuidof(WSLAUserSession), nullptr, CLSCTX_LOCAL_SERVER, IID_PPV_ARGS(&userSession)));
+        wil::com_ptr<IWSLASessionManager> userSession;


The variable is named userSession but now represents a global session manager, not a per-user session. Rename to manager or sessionManager for clarity and consistency with the test at line 2361.

src/windows/common/WslClient.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

OneBlue · 2026-01-16T04:11:26Z

test/windows/Common.cpp

 }

-wil::unique_handle GetNonElevatedToken()
+wil::unique_handle GetNonElevatedToken(TOKEN_TYPE Type)


Big thanks to @johnstep for his help in getting this right

OneBlue added 4 commits January 14, 2026 14:08

Save state

d1fc5a3

Save state

cf7e345

Save state

6af7574

Refactor WSLAUserSession into WSLASessionManager

5afa3fa

OneBlue changed the title ~~User/oneblue/session manager~~ Redesign WSLA Session management Jan 15, 2026

OneBlue added 7 commits January 15, 2026 11:04

Add test coverage

20223b1

Disconnect on service stop

0a73fde

Rework Delete() logic

d71137b

Fix WSL tests

b152f11

Use a different method to acquire non-elevated tokens

c4d29f3

Merge remote-tracking branch 'origin/feature/wsl-for-apps' into user/…

e94c98e

…oneblue/session-manager

Fix token generation logic

b923dfe

OneBlue marked this pull request as ready for review January 16, 2026 02:18

OneBlue requested a review from a team as a code owner January 16, 2026 02:18

Copilot AI review requested due to automatic review settings January 16, 2026 02:18

Copilot started reviewing on behalf of OneBlue January 16, 2026 02:19 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Apply suggestions from code review

d11d705

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

OneBlue commented Jan 16, 2026

View reviewed changes

OneBlue added 2 commits January 16, 2026 08:48

Fix naming issues

bef67e0

Revert token generation logic

3d89d36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Redesign WSLA Session management #14067

Redesign WSLA Session management #14067

Uh oh!

OneBlue commented Jan 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Copilot AI Jan 16, 2026

Uh oh!

Uh oh!

OneBlue Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Redesign WSLA Session management #14067

Are you sure you want to change the base?

Redesign WSLA Session management #14067

Uh oh!

Conversation

OneBlue commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OneBlue Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

OneBlue commented Jan 15, 2026 •

edited

Loading