Set Distro Env HOSTTYPE to aarch64 for ARM64 build#40048
Merged
Conversation
benhillis
requested changes
Mar 31, 2026
Member
benhillis
left a comment
There was a problem hiding this comment.
Instead of adding more #defines, can you do something similar to what we do for WSL_PACKAGE_VERSION?
Contributor
There was a problem hiding this comment.
Pull request overview
Updates WSL’s default distro environment so HOSTTYPE reflects the target architecture, fixing incorrect HOSTTYPE=x86_64 on ARM64 builds (issue #40040).
Changes:
- Introduce a build-time
DISTRO_HOSTTYPEdefine set tox86_64on x64 andaarch64on arm64. - Use
DISTRO_HOSTTYPEwhen constructing the default distro environment (both the IDL macro and the service-side default environment vector).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
CMakeLists.txt |
Defines DISTRO_HOSTTYPE based on TARGET_PLATFORM and exports it as a compile definition. |
src/windows/service/inc/wslservice.idl |
Switches LXSS_DISTRO_DEFAULT_ENVIRONMENT to build HOSTTYPE from DISTRO_HOSTTYPE. |
src/windows/service/exe/DistributionRegistration.h |
Updates the DefaultEnvironment default value to use DISTRO_HOSTTYPE instead of a hardcoded x86_64. |
benhillis
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Set Distro Env HOSTTYPE to aarch64 for ARM64 build
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed