wslc: ensure dns tunneling is disabled with virtioproxy networking mode#40057
Merged
benhillis merged 1 commit intofeature/wsl-for-appsfrom Apr 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures DNS tunneling is not used when the VM is operating with VirtioProxy networking, to avoid a known DNS-over-TCP issue, by gating configuration and VirtioProxy behavior in the Windows service/config layers.
Changes:
- Disables VirtioProxy’s internal DNS-tunneling behavior by no longer setting
VirtioNetworkingFlags::DnsTunneling. - Tightens config validation to only allow
EnableDnsTunnelingwhenNetworkingModeisNatorMirrored. - Adjusts the early-config message to always forward
EnableDnsTunneling(now relying on config validation to gate it).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/windows/service/exe/WslCoreVm.cpp |
Stops enabling DNS tunneling in the VirtioProxy networking engine and changes how the guest early-config is populated. |
src/windows/common/WslCoreConfig.cpp |
Updates config consistency rules to disallow DNS tunneling outside NAT/Mirrored. |
dkbennett
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that DNS tunneling is disabled for virtio proxy networking mode. There is currently a bug with DNS over TCP that I am debugging and will enable this functionality when the bug is fixed.