Skip to content

Fix country names to readable Chinese in rtchnlplan.h#1385

Open
andremueiot wants to merge 1 commit into
microsoft:mainfrom
andremueiot:user/andremueiot/rtchnlplan_chinese
Open

Fix country names to readable Chinese in rtchnlplan.h#1385
andremueiot wants to merge 1 commit into
microsoft:mainfrom
andremueiot:user/andremueiot/rtchnlplan_chinese

Conversation

@andremueiot
Copy link
Copy Markdown

@andremueiot andremueiot commented May 19, 2026

  1. Country name strings were updated from garbled mojibake text to readable Chinese text in the main country/domain table around rtchnlplan.h:102.
  2. Matching comment strings in the country enum section were updated the same way around rtchnlplan.h:261.
  3. No functional code logic changed:
    • Enum identifiers like RT_CTRY_AL, RT_CTRY_US, etc. are unchanged.
    • Domain code fields (2G_WORLD, 5G_ETSI1, etc.) are unchanged.
    • This is primarily a text/content cleanup plus minor spacing/alignment edits.

With these changes the writing in Chinese shows up properly in Visual Studio.

1. Country name strings were updated from garbled mojibake text to readable Chinese text in the main country/domain table around rtchnlplan.h:102.
2. Matching comment strings in the country enum section were updated the same way around rtchnlplan.h:261.
3. No functional code logic changed:
    - Enum identifiers like RT_CTRY_AL, RT_CTRY_US, etc. are unchanged.
    - Domain code fields (2G_WORLD, 5G_ETSI1, etc.) are unchanged.
    - This is primarily a text/content cleanup plus minor spacing/alignment edits.
@andremueiot andremueiot requested a review from a team as a code owner May 19, 2026 15:18
@andremueiot
Copy link
Copy Markdown
Author

@keith-horton , FYI.

@keith-horton
Copy link
Copy Markdown
Member

@keith-horton , FYI.

The web view of this change makes it look like they are practically identical :(
Are they different if I use another tool to compare them?

@andremueiot
Copy link
Copy Markdown
Author

@keith-horton , FYI.

The web view of this change makes it look like they are practically identical :( Are they different if I use another tool to compare them?

I was also surprised by seeing these changes shown as similar. But note that the coloring still shows up, so clearly the tool understands that there are differences.

When I have the file open in VS Code and switch from main to this branch I can clearly see the changes. I'm not sure why the web interface is not showing the contents that we saw in that other PR which was removing the trailing spaces. Maybe it's taking hints from the new changes?

Anyways, I'm convinced that these changes are good :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants