.NET: accept JSON string inline skill args#6214
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for inline skill script arguments provided as a JSON-encoded string (in addition to a JSON object), by attempting to parse string-valued JsonElement arguments into JSON before validating they form an object.
Changes:
- In
ConvertToFunctionArguments, when the incomingJsonElementis aString, parse it as JSON and use the resulting root element; throwInvalidOperationExceptionon parse failure. - Clone
JsonElementproperty values when sourced from the locally-parsedJsonDocumentso they remain valid after the document is disposed infinally. - Add two unit tests covering the JSON-string-of-object happy path and the invalid-JSON-string error path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI/Skills/Programmatic/AgentInlineSkillScript.cs | Accept JSON-string arguments by parsing them, with cloning + disposal to manage document lifetime. |
| dotnet/tests/Microsoft.Agents.AI.UnitTests/AgentSkills/AgentInlineSkillScriptTests.cs | Tests for parsed-string arguments and invalid-JSON-string error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6020.
Summary
To verify
dotnet restore tests\Microsoft.Agents.AI.UnitTests\Microsoft.Agents.AI.UnitTests.csprojdotnet test --project tests\Microsoft.Agents.AI.UnitTests\Microsoft.Agents.AI.UnitTests.csproj -- --filter-class Microsoft.Agents.AI.UnitTests.AgentSkills.AgentInlineSkillScriptTestsdotnet build src\Microsoft.Agents.AI\Microsoft.Agents.AI.csproj --no-restoredotnet format agent-framework-dotnet.slnx --include src\Microsoft.Agents.AI\Skills\Programmatic\AgentInlineSkillScript.cs tests\Microsoft.Agents.AI.UnitTests\AgentSkills\AgentInlineSkillScriptTests.cs --verify-no-changesgit diff --check