feat: add --local-source to E2E smoke test + fix input_schema test#52
Open
feat: add --local-source to E2E smoke test + fix input_schema test#52
Conversation
Adds --local-source flag to e2e-smoke-test.sh for cross-repo validation. Allows overriding additional packages (CLI, foundation, modules) with local checkouts during E2E testing. Each path is copied into the Docker container and installed with pip install --force-reinstall --no-deps.
Also fixes test_tool_protocol_defines_input_schema to test behavioral contract (using getattr with default) instead of Protocol metaclass introspection. Python's Protocol metaclass does not expose default property implementations via hasattr/vars, so the test now validates the actual calling pattern (getattr(tool, 'input_schema', {})).
## Testing
- 150 passed, 0 failed, 1 skipped
- E2E smoke test passes with 7 local overrides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds --local-source flag to e2e-smoke-test.sh for cross-repo validation. Also fixes test_tool_protocol_defines_input_schema to test behavioral contract instead of Protocol metaclass introspection.
--local-source
Allows overriding additional packages (CLI, foundation, modules) with local checkouts during E2E testing. Each path is copied into the Docker container and installed with pip install --force-reinstall --no-deps.
Testing