Update rhino to version 1.7.15.1#15374
Conversation
Add missing newline at the end of the file.
Buddy Build is Successful. Buddy Build to check the dependent package after fixing rhino - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011876&view=results |
sandeepkarambelkar
left a comment
There was a problem hiding this comment.
No any warnings in the build logs.
Buddy Build successful.
Changes LGTM
|
bsf builds successfully after this change. Can you add fix for license issues of bsf in the same PR? ##[warning]License issues found. |
|
Buddy Build to check dependent package license warnings fix - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1012747&view=results |
|
Buddy build after duplicate license file removal. |
kgodara912
left a comment
There was a problem hiding this comment.
As such changes look fine except license file. Please mark additional license info file proper as it was done in other PRs.
kgodara912
left a comment
There was a problem hiding this comment.
Buddy build is failing because of improper change.
buddy build is successful. |
Updated the release number and added a changelog entry for license fixes.
|
Buddy build after the recent changes. |
kgodara912
left a comment
There was a problem hiding this comment.
Please compile the packages before requesting a review. That way, it will save time for both of us for minor changes of changelog and other warnings. Also, once you update review, you can also first take a look as the diff in GitHub UI which will give you an idea of anything extra in PR like trailing spaces.
Updated the date for the changelog entry and fixed license warnings.
kgodara912
left a comment
There was a problem hiding this comment.
Buddy build is successful. Minor license correction for bsf package and version upgrade to rhino packages. LGTM.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
This is to upgrade the package rhino to version 1.7.15.1
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology