Add AWS S3 storage backend#534
Conversation
ecraig12345
left a comment
There was a problem hiding this comment.
Thanks for this PR, but most of the current users of lage/backfill won't want a tree of AWS dependencies pulled in by default.
An alternative would be to specify the AWS deps as peerDependencies that are marked as optional in peerDependenciesMeta (and update the provider to throw if the dep isn't present). The peer deps would need to be specified in both the backfill-cache and backfill packages.
Also, due to the potentially-missing dependency and the way lage's types rollup works, it would be best to avoid directly references the types in backfill-config--so clientConfig?: object in S3CacheStorageOptions.
|
|
Sorry for the extremely delayed response again. We just merged the Regarding this specific PR: I appreciate the contribution and recognize that it would likely be useful for others, but since our team has limited resources to devote to As an alternative, I realized recently that since most users of |
Add support for cache storage to AWS S3.