Add -AsTag parameter to Get-Version #1965

flanakin · 2026-01-31T22:22:53Z

🛠️ Description

Added -AsTag switch to Get-Version.ps1 that returns the full git tag (e.g., v13 instead of 13.0). Updated Package-Toolkit.ps1 to use it so zip filenames match release expectations (finops-hub-v13.zip instead of finops-hub-v13.0.zip). Updated Update-Version.ps1 to use it for writing ftktag.txt instead of inline regex.

📋 Checklist

🔬 How did you test this change?

🤏 Lint tests

🤞 PS -WhatIf / az validate

👍 Manually deployed + verified

💪 Unit tests

🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

🚨 This is a breaking change.

🤏 The change is less than 20 lines of code.

📑 Did you update `docs/changelog.md`?

✅ Updated changelog (required for dev PRs)

➡️ Will add log in a future PR (feature branch PRs only)

❎ Log not needed (small/internal change)

📖 Did you update documentation?

✅ Public docs in docs (required for dev)

✅ Public docs in docs-mslearn (required for dev)

✅ Internal dev docs in docs-wiki (required for dev)

✅ Internal dev docs in src (required for dev)

➡️ Will add docs in a future PR (feature branch PRs only)

❎ Docs not needed (small/internal change)

🤖 Generated with Claude Code

- Add -AsTag switch to Get-Version.ps1 that returns the full git tag (e.g., "v13") - Update Package-Toolkit.ps1 to use Get-Version -AsTag for zip filenames - Update Update-Version.ps1 to use Get-Version -AsTag for ftktag.txt Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

microsoft-github-policy-service · 2026-01-31T22:23:51Z

@flanakin please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

microsoft-github-policy-service · 2026-01-31T22:23:51Z

@flanakin please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Copilot

Pull request overview

Adds a new -AsTag switch to the version helper script and updates packaging/versioning scripts to use git-tag style versions (for example, v13) where needed.

Changes:

Added -AsTag switch to Get-Version.ps1 to return a git tag format (for example, v13).
Updated Update-Version.ps1 to use Get-Version -AsTag when writing ftktag.txt.
Updated Package-Toolkit.ps1 to use Get-Version -AsTag for packaging output naming (but this currently impacts non-zip uses of $version too).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
src/scripts/Get-Version.ps1	Adds `-AsTag` switch and updates help text/examples.
src/scripts/Update-Version.ps1	Uses `Get-Version -AsTag` to populate `ftktag.txt` (removes inline regex).
src/scripts/Package-Toolkit.ps1	Switches to tag-based version for ZIP naming, but currently also changes doc/deploy/version behaviors that appear to expect semantic `major.minor`.

Copilot · 2026-01-31T22:29:11Z

src/scripts/Package-Toolkit.ps1

        $zip = if ($unversionedZip) {
            Join-Path (Get-Item $relDir) "$templateName.zip"
        } else {
-            Join-Path (Get-Item $relDir) "$templateName-v$version.zip"
+            Join-Path (Get-Item $relDir) "$templateName-$version.zip"


The ZIP filename now uses $version directly. If $version is kept as semantic (e.g., 13.0), this will produce finops-hub-13.0.zip (dropping the expected v tag prefix). If $version remains a tag (v13), it affects other behaviors in this script (docs/deploy + ftkver.txt). Consider using a dedicated tag variable for ZIP naming (e.g., $tag = Get-Version -AsTag) and keep $version semantic for internal paths.

Copilot · 2026-01-31T22:29:11Z

src/scripts/Package-Toolkit.ps1

 function Copy-TemplateFiles()
 {
-    Write-Host "Packaging $(if ($Template) { "$Template v$version template" } else { "v$version templates" })..."
+    Write-Host "Packaging $(if ($Template) { "$Template $version template" } else { "$version templates" })..."


if ($Template) { ... } else { ... } will always take the first branch because $Template is a non-empty string by default ("*"). If the intent is to show the "all templates" message when packaging everything, check for $Template -eq '*' (or similar) instead of truthiness.

Suggested change

Write-Host "Packaging $(if ($Template) { "$Template $version template" } else { "$version templates" })..."

Write-Host "Packaging $(if ($Template -ne "*") { "$Template $version template" } else { "$version templates" })..."

Copilot · 2026-01-31T22:29:11Z

src/scripts/Get-Version.ps1

+    .PARAMETER AsTag
+    Optional. Returns the version as a git tag (e.g., "v13" instead of "13.0"). Default = false.
+
    .PARAMETER AsDotNetVersion
-    Optional. Indicates that the returned version should be in the format "x.x.x.x". Otherwise, semantic versioning is used. Deafult = false.
+    Optional. Indicates that the returned version should be in the format "x.x.x.x". Otherwise, semantic versioning is used. Default = false.



This change affects release/packaging behavior (new -AsTag switch and updated ZIP naming). Per repo standards, please add a corresponding entry to docs-mslearn/toolkit/changelog.md under the next release section so the behavior change is discoverable.

Copilot · 2026-01-31T22:29:11Z

src/scripts/Package-Toolkit.ps1

 }

-$version = & "$PSScriptRoot/Get-Version"
+$version = & "$PSScriptRoot/Get-Version" -AsTag


$version is now set to the git tag (e.g., v13), but later in this script $version is also used for doc/deploy naming and writing docs/_includes/ftkver.txt, which currently holds a semantic major.minor value (e.g., 13.0). Using v13 here will change the generated deploy file names/paths (currently *-13.0.*) and will overwrite ftkver.txt with a tag value. Keep $version as the semantic version and introduce a separate $tag (from Get-Version -AsTag) specifically for ZIP filenames / tag-specific paths.

Suggested change

$version = & "$PSScriptRoot/Get-Version" -AsTag

$version = & "$PSScriptRoot/Get-Version"

Keep $version as semantic version (13.0) for deploy paths and ftkver.txt, and use $tag (v13) only for zip filenames. Addresses PR review feedback. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings January 31, 2026 22:22

flanakin requested a review from arthurclares as a code owner January 31, 2026 22:22

Copilot started reviewing on behalf of flanakin January 31, 2026 22:23 View session

microsoft-github-policy-service bot requested a review from aromano2 January 31, 2026 22:23

microsoft-github-policy-service bot added Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed labels Jan 31, 2026

microsoft-github-policy-service bot assigned arthurclares Jan 31, 2026

microsoft-github-policy-service bot added the Skill: DevOps GitHub setup and automation label Jan 31, 2026

microsoft-github-policy-service bot assigned aromano2 Jan 31, 2026

flanakin added this to the v14 milestone Jan 31, 2026

Copilot AI reviewed Jan 31, 2026

View reviewed changes

Fix Package-Toolkit to use separate version and tag variables

67fe614

Keep $version as semantic version (13.0) for deploy paths and ftkver.txt, and use $tag (v13) only for zip filenames. Addresses PR review feedback. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add -AsTag parameter to Get-Version #1965

Add -AsTag parameter to Get-Version #1965

flanakin commented Jan 31, 2026

Uh oh!

microsoft-github-policy-service bot commented Jan 31, 2026

Contribution License Agreement

Uh oh!

microsoft-github-policy-service bot commented Jan 31, 2026

Contribution License Agreement

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	Write-Host "Packaging $(if ($Template) { "$Template $version template" } else { "$version templates" })..."
	Write-Host "Packaging $(if ($Template -ne "*") { "$Template $version template" } else { "$version templates" })..."

	$version = & "$PSScriptRoot/Get-Version" -AsTag
	$version = & "$PSScriptRoot/Get-Version"

Add -AsTag parameter to Get-Version #1965

Are you sure you want to change the base?

Add -AsTag parameter to Get-Version #1965

Conversation

flanakin commented Jan 31, 2026

🛠️ Description

📋 Checklist

🔬 How did you test this change?

🙋‍♀️ Do any of the following that apply?

📑 Did you update docs/changelog.md?

📖 Did you update documentation?

Uh oh!

microsoft-github-policy-service bot commented Jan 31, 2026

Contribution License Agreement

Uh oh!

microsoft-github-policy-service bot commented Jan 31, 2026

Contribution License Agreement

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

📑 Did you update `docs/changelog.md`?