feat: Add missing Bicep parameters to Deploy-FinOpsHub #1976
+89
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
requested review from
arthurclares and
flanakin
microsoft-github-policy-service
bot
added
the
Needs: Review 👀
RolandKrummenacher
force-pushed
the
feature/deploy-finopshub-missing-params
branch
2 times, most recently
from
f119ce0 to
3867499
Compare
RolandKrummenacher
force-pushed
the
feature/deploy-finopshub-missing-params
branch
2 times, most recently
from
3c09223 to
e426468
Compare
Added 8 missing parameters to align Deploy-FinOpsHub PowerShell cmdlet with all available Bicep template parameters: - EnablePurgeProtection (switch) - Enable purge protection for Key Vault - DisableManagedExports (switch) - Disable managed Cost Management exports - FabricQueryUri (string) - Microsoft Fabric eventhouse query URI - FabricCapacityUnits (int) - Fabric capacity units (1-2048) - TagsByResource (hashtable) - Resource-type specific tags - ScopesToMonitor (string[]) - Scope IDs to monitor - ExportRetentionInDays (int) - Export data retention - IngestionRetentionInMonths (int) - Ingestion data retention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Added 8 missing parameters to
Deploy-FinOpsHubPowerShell cmdlet to align with all available Bicep template parameters:-EnablePurgeProtection(switch) - Enable purge protection for Key Vault-DisableManagedExports(switch) - Disable managed Cost Management exports-FabricQueryUri(string) - Microsoft Fabric eventhouse query URI-FabricCapacityUnits(int) - Fabric capacity units (1-2048)-TagsByResource(hashtable) - Resource-type specific tags-ScopesToMonitor(string[]) - Scope IDs to monitor-ExportRetentionInDays(int) - Export data retention-IngestionRetentionInMonths(int) - Ingestion data retention📷 Screenshots
N/A - Code enhancement only
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?