FIx double onClick when invoking buttons via keyboard in Windows #3970
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in Windows platform I'm seeing a bug where invoking a Button via keyboard results in `onClick` being triggered twice, once from `onKeyUp` and once from `onKeyPressed`. This seemed like the appropriate place to make a fix, but let me know if there's a better place.
Saadnajmi
approved these changes
Nov 4, 2025
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
rurikoaraki
approved these changes
Nov 4, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in Windows platform I'm seeing a bug where invoking a Button via keyboard results in
onClickbeing triggered twice, once fromonKeyUpand once fromonKeyPressed. This seemed like the appropriate place to make a fix, but let me know if there's a better place.Platforms Impacted
Description of changes
Added 'windows' to shoudOnlyFireIfPressed.
Verification
Manually verified that windows Buttons were not firing onClick twice.
Pull request checklist
This PR has considered (when applicable):