Fix jacrev/jacfwd varying basis construction for JAX 0.10#43
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Collaborator
|
@dalin27 Thanks a lot! These changes make a lot of sense. Could you please rebase on main? Also it would be great if the function could be put into utils and also be used in the custom slogdet function such that all tests pass :) |
dalin27
force-pushed
the
dl/fix-jax-010-pvary-pcast
branch
from
3222c81 to
e486079
Compare
Contributor
Author
|
I rebased on main, moved the varying-marker helper into utils, reused it in the custom slogdet, and fixed the pre-existing split test failure. I also ran pytest locally and it passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jax.lax.pvarywas deprecated in JAX 0.8.2 and removed from the publicjax.laxAPI in JAX 0.10.0. JAX 0.10 also removedShapedArray.vma, replacing it withmanual_axis_type.varying.The new helpers preserve compatibility by:
manual_axis_type.varyingwhen available;vmaon older JAX versions;jax.lax.pcast(..., to="varying")when available;jax.lax.pvary(...)on older JAX versions.