Open
Conversation
…e bits that 'matter'; which is Dispose order fixing, SessionParseState fixing, and TLS disabling
kevin-montrose
requested review from
Copilot and
vazois
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Improves reliability of vector set migration and related infrastructure by fixing serialization length calculations, tightening migration error handling, adjusting server disposal ordering, and updating cluster test setup to better isolate TLS-related migration flakiness.
Changes:
- Fixes incorrect byte-count returns in
SessionParseStateandInputHeaderserialization/deserialization. - Reorders
GarnetServerdisposal phases to dispose network servers before storage provider shutdown. - Adds failure detection/logging to migration scan/transmit flow and introduces test hooks (TLS toggle + increased threadpool minimums).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Garnet.test.cluster/VectorSets/ClusterVectorSetTests.cs | Adds threadpool min threads tweak and a TLS toggle parameter for cluster setup used by tests. |
| libs/server/Resp/Parser/SessionParseState.cs | Fixes return value sign for byte counts in buffer copy/deserialize logic. |
| libs/server/InputHeader.cs | Fixes return value sign for byte counts in header deserialize logic. |
| libs/host/GarnetServer.cs | Reorders disposal to dispose servers before provider shutdown. |
| libs/cluster/Server/Migration/MigrateSessionSlots.cs | Makes migration tasks return bool, checks results, and handles TransmitSlots failures. |
| libs/cluster/Server/Migration/MigrateOperation.cs | Adds failure handling/logging when TransmitSlots returns false. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporates a number of separately reported fixes (for
SessionParseState,GarnetServerdisposal,InputHeaderserialization), clearingActiveThreadSessionin more error paths, and forces minimum io and worker threadpool threads to 512 in cluster tests.Each help reliability a bit, but threadpool hackery is a big win.
Additionally adds some extra error checking that, while not impactful for reliability, was helpful for eliminating possibilities while debugging.
devtargeting version is #1706