Plumb hash_envelope_reference_info.cose#2622
Open
anmaxvl wants to merge 1 commit into
Open
Conversation
MahatiC
reviewed
Mar 9, 2026
| } | ||
|
|
||
| func GetDefaultHashEnvelopeReferenceInfoFilePath() string { | ||
| return filepath.Join(defaultConfidentialWCOWOSBootFilesPath(), "hash_envelope_reference_info.cose") |
Member
There was a problem hiding this comment.
Heads-up that last time I was testing, the pipeline was producing snp_reference_info.cose instead of reference_info.cose which the code expects (line#95 above). One of them has to change. Same for hash_envelope_reference_info.cose - we need to make sure the name matches what the pipeline is producing (or vice-versa)
| // WithUVMHashEnvelopeReferenceInfo reads UVM hash envelope reference info file | ||
| // and base64 encodes the content before setting it for the resource. This is | ||
| // no-op if the `referenceName` is empty or the file doesn't exist. | ||
| func WithUVMHashEnvelopeReferenceInfo(referenceRoot string, referenceName string) ConfidentialUVMOpt { |
Member
There was a problem hiding this comment.
Can we refactor this? This and WithUVMReferenceInfo have the exact same code. We can have two different APIs, but just one place that is generating the encoded version which the APIs can call into.
Contributor
|
@anmaxvl Can you please port these changes into the new Builder too?
|
helsaawy
reviewed
Mar 17, 2026
| } | ||
|
|
||
| func GetDefaultHashEnvelopeReferenceInfoFilePath() string { | ||
| return filepath.Join(defaultConfidentialWCOWOSBootFilesPath(), "hash_envelope_reference_info.cose") |
Contributor
There was a problem hiding this comment.
Suggested change
| return filepath.Join(defaultConfidentialWCOWOSBootFilesPath(), "hash_envelope_reference_info.cose") | |
| return filepath.Join(defaultConfidentialWCOWOSBootFilesPath(), UVMHashEnvelopeReferenceInfoFile) |
anmaxvl
force-pushed
the
additional-cose-documents
branch
from
bd15999 to
0cac1d1
Compare
Add support for a new COSE_Sign1 signed document (reference_info_hash_envelope.cose) alongside the existing reference_info.cose. The file is read from the boot files directory, base64-encoded, sent to Linux/Windows guests via ConfidentialOptions, and written into each container's security context directory as transparent-reference-info-base64. A single platform-agnostic annotation (io.microsoft.virtualmachine.uvm-hash-envelope-reference-info-file) is used for both LCOW and WCOW. Changes: - Add UVMHashEnvelopeReferenceInfoFile annotation constant - Add DefaultUVMHashEnvelopeReferenceInfoFile to vmutils - Add EncodedUVMHashEnvelopeReference to guest protocol - Add WithUVMHashEnvelopeReferenceInfo confidential UVM option - Plumb new reference info through v1 shim (internal/uvm/) and v2 shim (internal/builder/ + internal/controller/) codepaths - Plumb to both linux GCS and windows gcs-sidecar Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
additional-cose-documents
branch
from
0cac1d1 to
9bb49e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for a new COSE_Sign1 signed document
(hash_envelope_reference_info.cose) alongside the existing reference_info.cose. The file is read from the boot files directory, base64-encoded, sent over the wire via LCOWConfidentialOptions, and written into each container's security context directory.
A single platform-agnostic annotation
(io.microsoft.virtualmachine.uvm-hash-envelope-reference-info-file) is used for both LCOW and WCOW, placed in a new "Confidential UVM annotations" section.
Changes: