Remove unused fields from LCOW SandboxOptions#2719
Merged
Conversation
…dboxOptions Agent-Logs-Url: https://github.com/microsoft/hcsshim/sessions/5b4958c5-1086-4f2b-8705-70c8f6a141ba Co-authored-by: rawahars <65640262+rawahars@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unused fields from SandboxOptions and LCOW Builder
Remove unused fields from LCOW SandboxOptions
May 4, 2026
…s in LCOW builder Agent-Logs-Url: https://github.com/microsoft/hcsshim/sessions/f2729ee4-3f81-4e0d-9cac-97f0153e27de Co-authored-by: rawahars <65640262+rawahars@users.noreply.github.com>
rawahars
approved these changes
May 4, 2026
shreyanshjain7174
approved these changes
May 4, 2026
Contributor
shreyanshjain7174
left a comment
shreyanshjain7174
left a comment
There was a problem hiding this comment.
LGTM — fields are genuinely unused, reject loop is a clean consolidation, tests are properly updated.
jterry75
approved these changes
May 4, 2026
Agent-Logs-Url: https://github.com/microsoft/hcsshim/sessions/e9eef610-ee26-4800-a063-7ec96478e41a Co-authored-by: rawahars <65640262+rawahars@users.noreply.github.com>
jterry75
approved these changes
May 4, 2026
rawahars
approved these changes
May 4, 2026
Copilot AI
added a commit
that referenced
this pull request
May 6, 2026
* Initial plan * Remove unused GuestDrivers and VPMEMMultiMapping fields from LCOW SandboxOptions Agent-Logs-Url: https://github.com/microsoft/hcsshim/sessions/5b4958c5-1086-4f2b-8705-70c8f6a141ba Co-authored-by: rawahars <65640262+rawahars@users.noreply.github.com> * Reject VPMemNoMultiMapping and VirtualMachineKernelDrivers annotations in LCOW builder Agent-Logs-Url: https://github.com/microsoft/hcsshim/sessions/f2729ee4-3f81-4e0d-9cac-97f0153e27de Co-authored-by: rawahars <65640262+rawahars@users.noreply.github.com> * Address review: add comment explaining unsupported annotations Agent-Logs-Url: https://github.com/microsoft/hcsshim/sessions/e9eef610-ee26-4800-a063-7ec96478e41a Co-authored-by: rawahars <65640262+rawahars@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rawahars <65640262+rawahars@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GuestDriversandVPMEMMultiMappingfields frominternal/builder/vm/lcow/sandbox_options.goparseSandboxOptionsininternal/builder/vm/lcow/specs.go(including theosversionimport that became unused)VPMEMMultiMappingparity check fromtest/parity/vm/lcow_doc_test.goVPMemNoMultiMappingorVirtualMachineKernelDriversannotations are set (matching the existingNetworkConfigProxypattern inprocessAnnotations)VPMemNoMultiMappingtest case so it doesn't conflict with the new erroruvm.CreateLCOWpath) — addresses PR #2719 review comment