-
Notifications
You must be signed in to change notification settings - Fork 337
AMLFS autoimport and autoexport commands (create, get, list, cancel, and delete) #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
913232b to
823fecf
Compare
....Mcp.Tools.ManagedLustre/src/Commands/FileSystem/AutoexportJob/AutoexportJobCancelCommand.cs
Outdated
Show resolved
Hide resolved
...ols.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.LiveTests/ManagedLustreCommandTests.cs
Outdated
Show resolved
Hide resolved
...ols.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.LiveTests/ManagedLustreCommandTests.cs
Outdated
Show resolved
Hide resolved
...ols.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.LiveTests/ManagedLustreCommandTests.cs
Outdated
Show resolved
Hide resolved
121770c to
d8a9905
Compare
d076253 to
3b27b45
Compare
3b27b45 to
70dfab1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive support for Azure Managed Lustre HSM (Hierarchical Storage Management) operations by implementing autoimport and autoexport job management commands. These commands enable data synchronization between Azure Managed Lustre filesystems and Azure Blob Storage.
Key changes:
- Adds 8 new MCP commands for autoimport/autoexport job lifecycle management (create, get, cancel, delete for both job types)
- Updates test infrastructure with improved Bicep templates and role assignment handling
- Implements comprehensive unit and live tests with proper test collection sequencing
Reviewed changes
Copilot reviewed 46 out of 46 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.ManagedLustre/tests/test-resources.bicep | Refactored Bicep template to properly configure HSM storage accounts with required permissions and blob change feed |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/test-resources-pre.ps1 | Added pre-deployment script to resolve HPC Cache RP service principal |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/test-resources-post.ps1 | Commented out post-deployment verification logic |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Services/ManagedLustreService.cs | Implements all autoimport/autoexport service methods with proper validation and error handling |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Services/IManagedLustreService.cs | Defines service interface for autoimport/autoexport operations |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/Autoimport*/Autoexport* | Implements command classes for all autoimport and autoexport operations |
| tools/Azure.Mcp.Tools.ManagedLustre/src/Models/*.cs | Defines AutoimportJob and AutoexportJob models |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.UnitTests | Comprehensive unit tests for all new commands |
| tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.LiveTests | Live tests with sequential execution to prevent job conflicts |
| servers/Azure.Mcp.Server/CHANGELOG.md | Documents new commands and features |
| servers/Azure.Mcp.Server/docs/azmcp-commands.md | Adds command documentation with usage examples |
| Directory.Packages.props | Updates Azure.ResourceManager.StorageCache to version 1.4.0 |
...cp.Tools.ManagedLustre.UnitTests/FileSystem/AutoexportJob/AutoexportJobCancelCommandTests.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.ManagedLustre/src/Services/ManagedLustreService.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.ManagedLustre/src/Services/ManagedLustreService.cs
Outdated
Show resolved
Hide resolved
...ols.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.LiveTests/ManagedLustreCommandTests.cs
Outdated
Show resolved
Hide resolved
...ols.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.LiveTests/ManagedLustreCommandTests.cs
Outdated
Show resolved
Hide resolved
...ols.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.LiveTests/ManagedLustreCommandTests.cs
Outdated
Show resolved
Hide resolved
...ols.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.LiveTests/ManagedLustreCommandTests.cs
Outdated
Show resolved
Hide resolved
63d12a7 to
f22b8fa
Compare
2a15f9a to
64af9ca
Compare
What does this PR do?
For AMLFS (azure managed lustre filesystem) add auto import and auto export commands (create, get, list, cancel, and delete).
GitHub issue number?
1087
1086
1085
1084
1083
1109
1349
1350
1351
1352
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline