Skip to content

Conversation

@rebecca-makar
Copy link

@rebecca-makar rebecca-makar commented Dec 17, 2025

What does this PR do?

For AMLFS (azure managed lustre filesystem) add auto import and auto export commands (create, get, list, cancel, and delete).

GitHub issue number?

1087
1086
1085
1084
1083
1109
1349
1350
1351
1352

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@rebecca-makar rebecca-makar force-pushed the remakar/amlfs-autoexport-and-autoimport branch 2 times, most recently from 121770c to d8a9905 Compare December 18, 2025 20:36
@rebecca-makar rebecca-makar force-pushed the remakar/amlfs-autoexport-and-autoimport branch from d076253 to 3b27b45 Compare January 6, 2026 17:15
@rebecca-makar rebecca-makar marked this pull request as ready for review January 6, 2026 17:16
@rebecca-makar rebecca-makar requested review from a team as code owners January 6, 2026 17:16
Copilot AI review requested due to automatic review settings January 6, 2026 17:16
@rebecca-makar rebecca-makar requested a review from a team as a code owner January 6, 2026 17:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive support for Azure Managed Lustre HSM (Hierarchical Storage Management) operations by implementing autoimport and autoexport job management commands. These commands enable data synchronization between Azure Managed Lustre filesystems and Azure Blob Storage.

Key changes:

  • Adds 8 new MCP commands for autoimport/autoexport job lifecycle management (create, get, cancel, delete for both job types)
  • Updates test infrastructure with improved Bicep templates and role assignment handling
  • Implements comprehensive unit and live tests with proper test collection sequencing

Reviewed changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
tools/Azure.Mcp.Tools.ManagedLustre/tests/test-resources.bicep Refactored Bicep template to properly configure HSM storage accounts with required permissions and blob change feed
tools/Azure.Mcp.Tools.ManagedLustre/tests/test-resources-pre.ps1 Added pre-deployment script to resolve HPC Cache RP service principal
tools/Azure.Mcp.Tools.ManagedLustre/tests/test-resources-post.ps1 Commented out post-deployment verification logic
tools/Azure.Mcp.Tools.ManagedLustre/src/Services/ManagedLustreService.cs Implements all autoimport/autoexport service methods with proper validation and error handling
tools/Azure.Mcp.Tools.ManagedLustre/src/Services/IManagedLustreService.cs Defines service interface for autoimport/autoexport operations
tools/Azure.Mcp.Tools.ManagedLustre/src/Commands/FileSystem/Autoimport*/Autoexport* Implements command classes for all autoimport and autoexport operations
tools/Azure.Mcp.Tools.ManagedLustre/src/Models/*.cs Defines AutoimportJob and AutoexportJob models
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.UnitTests Comprehensive unit tests for all new commands
tools/Azure.Mcp.Tools.ManagedLustre/tests/Azure.Mcp.Tools.ManagedLustre.LiveTests Live tests with sequential execution to prevent job conflicts
servers/Azure.Mcp.Server/CHANGELOG.md Documents new commands and features
servers/Azure.Mcp.Server/docs/azmcp-commands.md Adds command documentation with usage examples
Directory.Packages.props Updates Azure.ResourceManager.StorageCache to version 1.4.0

@rebecca-makar rebecca-makar force-pushed the remakar/amlfs-autoexport-and-autoimport branch from 63d12a7 to f22b8fa Compare January 7, 2026 18:40
@rebecca-makar rebecca-makar force-pushed the remakar/amlfs-autoexport-and-autoimport branch from 2a15f9a to 64af9ca Compare January 7, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

4 participants