Skip to content

Conversation

@gramalingam
Copy link
Collaborator

@gramalingam gramalingam commented Dec 29, 2025

More cleanup (in the migration of converter to onnx IR):

  • Eliminate some redundant info/logic (class Dynamic)
  • Cleanup AttrRef and SymbolValue.

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.09%. Comparing base (8c6084c) to head (c8c2f57).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
onnxscript/_internal/converter.py 81.08% 2 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2752      +/-   ##
==========================================
- Coverage   70.10%   70.09%   -0.01%     
==========================================
  Files         228      228              
  Lines       27393    27382      -11     
  Branches     2781     2783       +2     
==========================================
- Hits        19203    19194       -9     
+ Misses       7234     7229       -5     
- Partials      956      959       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gramalingam and others added 6 commits December 29, 2025 14:51
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@gramalingam gramalingam changed the title [DRAFT] Cleanup SymbolValue Cleanup SymbolValue Dec 30, 2025
@justinchuby justinchuby merged commit 519ef5a into main Dec 30, 2025
32 of 33 checks passed
@justinchuby justinchuby deleted the rama/cleanup2 branch December 30, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants