netvsp: Patches to fully enable VLAN support#3552
Open
ben-zen wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Underhill NetVSP’s RNDIS capability advertisement so VLAN-tagged traffic can be properly handled by the client during synthetic path operation, addressing a missing piece from #3417.
Changes:
- Advertise 802.1p priority and 802.1Q VLAN support in
OID_GEN_MAC_OPTIONSresponses so the client can enable VLAN behavior.
ben-zen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once a test environment could be set up to explore Underhill/VLAN behavior, there were a few details that weren't obvious previously and could really only be seen in a live environment. This PR cleans up bugs or missing details from #3417, and fully enables VLAN traffic over Underhill's NetVSP interface.