Skip to content

openvmm/ttrpc/repl: Extend ttrpc interface and repl command list to support bind/unbind requests for consommé #3566

Open
damanm24 wants to merge 8 commits into
microsoft:mainfrom
damanm24:bind-port-rpc
Open

openvmm/ttrpc/repl: Extend ttrpc interface and repl command list to support bind/unbind requests for consommé #3566
damanm24 wants to merge 8 commits into
microsoft:mainfrom
damanm24:bind-port-rpc

Conversation

@damanm24
Copy link
Copy Markdown
Contributor

This PR builds on top of the work done in #3364 by extending OpenVMM's ttrpc interface to include port-forwarding commands. I also ended up adding the bind/unbind port commands to OpenVMM's REPL command list when testing the changes.

Copilot AI review requested due to automatic review settings May 26, 2026 18:29
@damanm24 damanm24 requested a review from a team as a code owner May 26, 2026 18:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the Consomme networking backend to support runtime port-forward bind/unbind requests (via a mesh channel), and wires this capability into OpenVMM’s ttrpc VMService API and the interactive REPL so ports can be managed after VM creation.

Changes:

  • Add a cross-proc Consomme port request channel (ConsommeRequest) and plumb it through ConsommeHandle to the net_consomme endpoint.
  • Update net_consomme to handle initial port forwards plus runtime bind/unbind requests (creating/binding host sockets on demand).
  • Extend the ttrpc proto and OpenVMM REPL command set to expose bind/unbind operations.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
vm/devices/net/net_consomme/src/resolver.rs Switch Consomme endpoint construction to optionally enable runtime port request handling via an injected receiver.
vm/devices/net/net_consomme/src/lib.rs Replace pre-bound socket forwarding with on-demand socket binding; add runtime bind/unbind request processing path.
vm/devices/net/net_backend_resources/src/lib.rs Introduce ConsommeRequest and add an optional runtime request receiver to ConsommeHandle.
petri/src/vm/openvmm/modify.rs Update ConsommeHandle construction to include the new recv field (set to None).
openvmm/openvmm_ttrpc_vmservice/src/vmservice.proto Add port-forwarding types (IpProtocol, PortConfig) and extend ConsommeBackend with ports.
openvmm/openvmm_entry/src/ttrpc/mod.rs Add a Consomme port request sender to VM state and implement ModifyResource-based bind/unbind operations.
openvmm/openvmm_entry/src/repl.rs Add bind-port / unbind-port REPL commands that send Consomme bind/unbind requests.
openvmm/openvmm_entry/src/lib.rs Create and retain a Consomme port request sender for REPL-driven runtime port operations (CLI path).

Comment thread openvmm/openvmm_entry/src/ttrpc/mod.rs
Comment thread openvmm/openvmm_entry/src/ttrpc/mod.rs
Comment thread openvmm/openvmm_entry/src/ttrpc/mod.rs
Comment thread openvmm/openvmm_entry/src/lib.rs
Comment thread openvmm/openvmm_entry/src/ttrpc/mod.rs
Copilot AI review requested due to automatic review settings May 26, 2026 19:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Comment thread openvmm/openvmm_entry/src/ttrpc/mod.rs
Comment thread openvmm/openvmm_entry/src/ttrpc/mod.rs
Comment thread vm/devices/net/net_consomme/src/lib.rs
Comment thread vm/devices/net/net_consomme/src/lib.rs
@github-actions
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants