vmm_tests_run: selections and deps improvements#3568
Open
tjones60 wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the local xflowey vmm-tests-run pipeline by refining dependency installation/verification on Windows, improving artifact/build selection so only necessary OpenHCL recipes are built, and adding a --disable-secure-avic option that flows into IGVM generation.
Changes:
- Refactors Windows test dependency installation to better handle registry keys/feature checks and to surface “restart required” after changes.
- Improves artifact resolution/build selection so only the required OpenHCL IGVM recipes are built (standard/dev/cvm/linux-direct).
- Adds
--disable-secure-avictovmm-tests-runand plumbs it through OpenHCL IGVM building.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| support/powershell_builder/src/lib.rs | Makes the PowerShell builder crate compile outside cfg(windows) (needed for WSL/Linux-host flowey compilation). |
| support/powershell_builder/Cargo.toml | Makes dependencies unconditional (no longer Windows-target-only). |
| flowey/flowey_lib_hvlite/src/install_vmm_tests_deps.rs | Refactors Windows dependency install/check logic; adds restart-required signaling; updates registry key handling including correct hardware isolation path. |
| flowey/flowey_lib_hvlite/src/build_openhcl_igvm_from_recipe.rs | Moves disable_secure_avic feature configuration into the recipe build path. |
| flowey/flowey_lib_hvlite/src/_jobs/local_build_igvm.rs | Removes duplicate disable_secure_avic feature insertion (now handled centrally in recipe build). |
| flowey/flowey_lib_hvlite/src/_jobs/local_build_and_run_nextest_vmm_tests.rs | Splits OpenHCL build selections by recipe type and builds only what’s needed; plumbs disable_secure_avic. |
| flowey/flowey_lib_hvlite/Cargo.toml | Makes powershell_builder an unconditional dependency (needed because it’s referenced from non-cfg(windows) code paths). |
| flowey/flowey_hvlite/src/pipelines/vmm_tests_run.rs | Adds --disable-secure-avic, improves selection logging, and improves hyperv/hardware-isolation detection from selected tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the following improvements to
xflowey vmm_tests_run:--install-missing-depsin a way that doesn't require admin.--build-only; this was already the case when the tests were not run locally) is copied to another machine later without the deps installed on the machine that built and ran the tests originally.