storvsc: Add docs to fix a warning#3576
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR eliminates an “unfulfilled lint expectation” warning in storvsc_driver by removing a #![expect(missing_docs)] module attribute and adding Rust doc comments to the newly-public test helper API so the module can compile cleanly across feature combinations.
Changes:
- Removed
#![expect(missing_docs)]from the storvsc test helpers module. - Added
///documentation toTestStorvscWorkerand its public methods to satisfy missing-docs linting when the module is exposed.
damanm24
approved these changes
May 27, 2026
benhillis
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing_docs expectation here was showing up as unfulfilled in certain builds with certain feature combinations. Fix this by just adding docs.