Skip to content

Template should import Microsoft.Cpp.Default.props before setting ReactNativeWindowsDir#16146

Open
acoates-ms wants to merge 3 commits into
microsoft:mainfrom
acoates-ms:defaultpropsBeforeRNWDir
Open

Template should import Microsoft.Cpp.Default.props before setting ReactNativeWindowsDir#16146
acoates-ms wants to merge 3 commits into
microsoft:mainfrom
acoates-ms:defaultpropsBeforeRNWDir

Conversation

@acoates-ms
Copy link
Copy Markdown
Contributor

@acoates-ms acoates-ms commented May 17, 2026 •
edited by microsoft-github-policy-service Bot
Loading

Currently the templates will set ReactNativeWindowsDir before importing Microsoft.Cpp.Default.prop, which means that projects that attempt to override ReactNativeWindowsDir in Directory.Build.props will be unable to do so.

Microsoft Reviewers: Open in CodeFlow

@acoates-ms acoates-ms requested a review from a team as a code owner May 17, 2026 23:59
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026 •
edited
Loading

Performance Test Results

Branch: defaultpropsBeforeRNWDir
Commit: 4bd4064a
Time: 2026-05-18T16:45:54.521Z
Tests: 161/161 passed

✅ Passed

161 scenario(s) across 28 suite(s) — no regressions

SectionList

Scenario Mean Median StdDev Renders vs Baseline
SectionList mount 5.50ms 5.00ms ±1.65ms 1 +0.0%
SectionList unmount 0.50ms 0.00ms ±1.27ms 0 +0.0%
SectionList rerender 11.10ms 10.50ms ±1.60ms 2 +0.0%
SectionList with-3-sections-15-items 5.20ms 5.00ms ±0.42ms 1 -9.1%
SectionList with-5-sections-50-items 9.10ms 6.00ms ±7.78ms 1 +0.0%
SectionList with-10-sections-200-items 5.30ms 5.00ms ±0.48ms 1 -9.1%
SectionList with-20-sections-200-items 5.10ms 5.00ms ±1.97ms 1 +0.0%
SectionList with-section-separator 1.70ms 2.00ms ±0.48ms 1 +0.0%
SectionList with-item-separator 2.60ms 2.00ms ±1.26ms 1 +0.0%
SectionList with-header-footer 1.80ms 2.00ms ±0.42ms 1 +0.0%
SectionList with-section-footer 1.70ms 2.00ms ±0.48ms 1 +0.0%
SectionList with-sticky-section-headers 2.00ms 2.00ms ±0.47ms 1 +0.0%
SectionList with-empty-list 0.50ms 0.50ms ±0.53ms 1 -50.0%
SectionList with-50-sections-1000-items 1.70ms 2.00ms ±0.48ms 1 +0.0%

FlatList

Scenario Mean Median StdDev Renders vs Baseline
FlatList mount 4.60ms 4.50ms ±0.70ms 1 +12.5%
FlatList unmount 0.20ms 0.00ms ±0.42ms 0 +0.0%
FlatList rerender 10.50ms 10.00ms ±1.58ms 2 +11.1%
FlatList with-10-items 4.70ms 5.00ms ±0.48ms 1 +25.0%
FlatList with-100-items 5.50ms 5.00ms ±1.84ms 1 +0.0%
FlatList with-500-items 4.60ms 5.00ms ±0.52ms 1 +25.0%
FlatList with-1000-items 4.90ms 4.50ms ±1.52ms 1 +12.5%
FlatList horizontal 4.00ms 4.00ms ±1.15ms 1 -20.0%
FlatList with-separator 1.70ms 1.00ms ±1.64ms 1 -50.0%
FlatList with-header-footer 1.90ms 2.00ms ±0.32ms 1 +0.0%
FlatList with-empty-list 0.40ms 0.00ms ±0.52ms 1 -100.0%
FlatList with-get-item-layout 1.70ms 2.00ms ±0.48ms 1 +100.0%
FlatList inverted 1.90ms 1.50ms ±1.52ms 1 +0.0%
FlatList with-num-columns 2.60ms 3.00ms ±0.52ms 1 +0.0%

TouchableOpacity

Scenario Mean Median StdDev Renders vs Baseline
TouchableOpacity mount 1.10ms 1.00ms ±0.74ms 1 +0.0%
TouchableOpacity unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
TouchableOpacity rerender 0.90ms 1.00ms ±0.32ms 2 +0.0%
TouchableOpacity custom-active-opacity 0.70ms 1.00ms ±0.48ms 1 +0.0%
TouchableOpacity disabled 0.40ms 0.00ms ±0.52ms 1 -100.0%
TouchableOpacity with-all-handlers 0.60ms 1.00ms ±0.52ms 1 +0.0%
TouchableOpacity with-hit-slop 0.90ms 1.00ms ±0.32ms 1 +0.0%
TouchableOpacity with-delay 0.60ms 1.00ms ±0.52ms 1 +0.0%
TouchableOpacity nested 1.10ms 1.00ms ±0.32ms 1 +0.0%
TouchableOpacity multiple-10 5.80ms 5.00ms ±2.08ms 1 -16.7%
TouchableOpacity multiple-50 26.33ms 26.00ms ±2.38ms 1 -10.3%
TouchableOpacity multiple-100 32.00ms 25.00ms ±13.09ms 1 -50.0%

ScrollView

Scenario Mean Median StdDev Renders vs Baseline
ScrollView mount 0.30ms 0.00ms ±0.48ms 1 +0.0%
ScrollView unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
ScrollView rerender 0.50ms 0.50ms ±0.53ms 2 -50.0%
ScrollView children-20 3.20ms 3.00ms ±0.56ms 1 -25.0%
ScrollView children-100 16.27ms 17.00ms ±2.55ms 1 +6.3%
ScrollView horizontal 3.30ms 3.00ms ±0.48ms 1 -25.0%
ScrollView sticky-headers 3.30ms 3.00ms ±1.34ms 1 +0.0%
ScrollView scroll-indicators 0.60ms 1.00ms ±0.52ms 1 +0.0%
ScrollView nested 1.30ms 1.00ms ±0.67ms 1 +0.0%
ScrollView content-container-style 0.70ms 1.00ms ±0.48ms 1 +0.0%
ScrollView children-500 20.20ms 19.00ms ±3.43ms 1 +0.0%

TouchableHighlight

Scenario Mean Median StdDev Renders vs Baseline
TouchableHighlight mount 0.40ms 0.00ms ±0.52ms 1 -100.0%
TouchableHighlight unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
TouchableHighlight rerender 0.60ms 1.00ms ±0.52ms 2 +0.0%
TouchableHighlight custom-underlay-color 0.70ms 1.00ms ±0.48ms 1 +Infinity%
TouchableHighlight custom-active-opacity 0.40ms 0.00ms ±0.52ms 1 +0.0%
TouchableHighlight disabled 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight with-all-handlers 0.50ms 0.50ms ±0.53ms 1 +Infinity%
TouchableHighlight with-hit-slop 0.30ms 0.00ms ±0.48ms 1 +0.0%
TouchableHighlight nested-touchables 0.80ms 1.00ms ±0.42ms 1 +0.0%
TouchableHighlight multiple-touchables-10 2.50ms 2.50ms ±0.53ms 1 -16.7%
TouchableHighlight multiple-touchables-50 13.50ms 13.50ms ±1.84ms 1 +8.0%
TouchableHighlight multiple-touchables-100 25.50ms 25.00ms ±2.27ms 1 +11.1%

Pressable

Scenario Mean Median StdDev Renders vs Baseline
Pressable mount 0.50ms 0.50ms ±0.53ms 1 +Infinity%
Pressable unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Pressable rerender 0.50ms 0.50ms ±0.53ms 2 +0.0%
Pressable with-all-handlers 0.50ms 0.50ms ±0.53ms 1 +Infinity%
Pressable with-style-function 0.40ms 0.00ms ±0.52ms 1 +0.0%
Pressable disabled 0.30ms 0.00ms ±0.48ms 1 +0.0%
Pressable with-hit-slop 0.40ms 0.00ms ±0.52ms 1 +0.0%
Pressable nested 0.70ms 1.00ms ±0.48ms 1 +0.0%
Pressable multiple-10 3.13ms 3.00ms ±0.35ms 1 +0.0%
Pressable multiple-50 16.73ms 16.00ms ±1.94ms 1 +14.3%
Pressable multiple-100 16.93ms 13.00ms ±9.92ms 1 +8.3%

Modal

Scenario Mean Median StdDev Renders vs Baseline
Modal mount 0.40ms 0.00ms ±0.52ms 1 +0.0%
Modal unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Modal rerender 0.20ms 0.00ms ±0.42ms 2 +0.0%
Modal slide-animation 0.20ms 0.00ms ±0.42ms 1 +0.0%
Modal fade-animation 0.30ms 0.00ms ±0.48ms 1 +0.0%
Modal transparent 0.30ms 0.00ms ±0.48ms 1 +0.0%
Modal with-callbacks 0.20ms 0.00ms ±0.42ms 1 +0.0%
Modal rich-content 1.50ms 1.50ms ±0.53ms 1 -25.0%
Modal with-accessibility 0.40ms 0.00ms ±0.52ms 1 +0.0%

Image

Scenario Mean Median StdDev Renders vs Baseline
Image mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
Image unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Image rerender 0.30ms 0.00ms ±0.48ms 2 +0.0%
Image with-resize-mode 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image with-border-radius 0.20ms 0.00ms ±0.42ms 1 +0.0%
Image with-tint-color 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image with-blur-radius 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image with-accessibility 0.10ms 0.00ms ±0.32ms 1 +0.0%
Image multiple-10 0.80ms 1.00ms ±0.41ms 1 +0.0%
Image multiple-50 3.80ms 4.00ms ±0.86ms 1 +33.3%
Image multiple-100 8.27ms 8.00ms ±1.22ms 1 +0.0%

ActivityIndicator

Scenario Mean Median StdDev Renders vs Baseline
ActivityIndicator mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
ActivityIndicator unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
ActivityIndicator rerender 0.30ms 0.00ms ±0.48ms 2 +0.0%
ActivityIndicator size-large 0.10ms 0.00ms ±0.32ms 1 +0.0%
ActivityIndicator size-small 0.20ms 0.00ms ±0.42ms 1 +0.0%
ActivityIndicator with-color 0.10ms 0.00ms ±0.32ms 1 +0.0%
ActivityIndicator not-animating 0.20ms 0.00ms ±0.42ms 1 +0.0%
ActivityIndicator with-accessibility 0.00ms 0.00ms ±0.00ms 1 +0.0%
ActivityIndicator multiple-10 1.00ms 1.00ms ±0.00ms 1 +0.0%
ActivityIndicator multiple-50 3.73ms 4.00ms ±1.10ms 1 +0.0%
ActivityIndicator multiple-100 8.13ms 8.00ms ±1.06ms 1 +14.3%

Switch

Scenario Mean Median StdDev Renders vs Baseline
Switch mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
Switch unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
Switch rerender 0.40ms 0.00ms ±0.52ms 2 -100.0%
Switch value-true 0.70ms 0.00ms ±1.25ms 1 +0.0%
Switch disabled 0.20ms 0.00ms ±0.42ms 1 +0.0%
Switch custom-colors 0.10ms 0.00ms ±0.32ms 1 +0.0%
Switch on-value-change 0.20ms 0.00ms ±0.42ms 1 +0.0%
Switch with-accessibility 0.20ms 0.00ms ±0.42ms 1 +0.0%
Switch multiple-10 1.80ms 2.00ms ±0.41ms 1 +0.0%
Switch multiple-50 10.67ms 9.00ms ±3.77ms 1 +0.0%
Switch multiple-100 20.13ms 18.00ms ±4.52ms 1 +12.5%

Button

Scenario Mean Median StdDev Renders vs Baseline
Button mount 0.50ms 0.50ms ±0.53ms 1 -50.0%
Button unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
Button rerender 1.10ms 1.00ms ±0.57ms 2 +0.0%
Button disabled 0.60ms 1.00ms ±0.52ms 1 +0.0%
Button with-color 0.60ms 1.00ms ±0.52ms 1 +100.0%
Button with-accessibility 0.60ms 1.00ms ±0.52ms 1 +0.0%
Button multiple-10 6.60ms 6.00ms ±1.80ms 1 +0.0%
Button multiple-50 26.07ms 29.00ms ±9.34ms 1 +7.4%
Button multiple-100 18.67ms 19.00ms ±3.98ms 1 +0.0%

TextInput

Scenario Mean Median StdDev Renders vs Baseline
TextInput mount 0.20ms 0.00ms ±0.42ms 1 +0.0%
TextInput unmount 0.00ms 0.00ms ±0.00ms 0 +0.0%
TextInput rerender 0.10ms 0.00ms ±0.32ms 2 +0.0%
TextInput multiline 0.10ms 0.00ms ±0.32ms 1 +0.0%
TextInput with-value 0.10ms 0.00ms ±0.32ms 1 +0.0%
TextInput styled 0.20ms 0.00ms ±0.42ms 1 +0.0%
TextInput multiple-100 8.47ms 8.00ms ±3.02ms 1 +14.3%

View

Scenario Mean Median StdDev Renders vs Baseline
View mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
View unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
View rerender 0.20ms 0.00ms ±0.42ms 2 +0.0%
View nested-50 3.80ms 4.00ms ±0.41ms 1 +33.3%
View nested-100 9.73ms 9.00ms ±2.02ms 1 +28.6%
View shadow 0.00ms 0.00ms ±0.00ms 1 +0.0%
View border-radius 0.00ms 0.00ms ±0.00ms 1 +0.0%
View nested-500 19.07ms 12.00ms ±16.21ms 1 +20.0%

Text

Scenario Mean Median StdDev Renders vs Baseline
Text mount 0.10ms 0.00ms ±0.32ms 1 +0.0%
Text unmount 0.10ms 0.00ms ±0.32ms 0 +0.0%
Text rerender 0.30ms 0.00ms ±0.48ms 2 +0.0%
Text long-1000 0.30ms 0.00ms ±0.48ms 1 +0.0%
Text nested 0.30ms 0.00ms ±0.48ms 1 +0.0%
Text styled 0.10ms 0.00ms ±0.32ms 1 +0.0%
Text multiple-100 9.07ms 9.00ms ±2.12ms 1 +28.6%

SectionList.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
SectionList native mount 5.11ms 4.75ms ±0.94ms 1 -27.0%

FlatList.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
FlatList native mount 5.23ms 4.70ms ±1.24ms 1 -49.1%

TouchableHighlight.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TouchableHighlight native mount 1.57ms 1.55ms ±0.17ms 1 -25.6%

TouchableOpacity.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TouchableOpacity native mount 2.02ms 1.86ms ±0.53ms 1 -40.7%

Pressable.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Pressable native mount 1.35ms 1.31ms ±0.18ms 1 -47.9%

ScrollView.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
ScrollView native mount 3.08ms 2.94ms ±0.46ms 1 -27.3%

ActivityIndicator.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
ActivityIndicator native mount 1.52ms 1.34ms ±0.49ms 1 -45.9%

TextInput.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
TextInput native mount 2.42ms 2.21ms ±0.75ms 1 -45.9%

Switch.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Switch native mount 1.55ms 1.33ms ±0.67ms 1 -23.4%

Button.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Button native mount 1.94ms 1.81ms ±0.27ms 1 -30.4%

Modal.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Modal native mount 0.99ms 0.89ms ±0.31ms 1 -26.7%

Image.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Image native mount 2.07ms 1.82ms ±0.98ms 1 -19.3%

View.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
View native mount 1.13ms 1.10ms ±0.23ms 1 -22.7%

Text.native-perf-test.ts

Scenario Mean Median StdDev Renders vs Baseline
Text native mount 1.33ms 1.31ms ±0.17ms 1 -24.9%

@tido64 tido64 mentioned this pull request May 18, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vineethkuttan vineethkuttan vineethkuttan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@acoates-ms @vineethkuttan