Skip to content

Fix Accessibility Violation: Improve accessibility of suite navigation bar #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huangkevin-apr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Accessibility Violation: Improve accessibility of suite navigation bar #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions plugins/theme-rushstack-suite-nav/src/theme/Root/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,14 @@ class Root extends React.Component<React.PropsWithChildren<{}>> {

return (
<>
<div className={styles.suiteNavBar}>
<nav className={styles.suiteNavBar}>
<div
role="button"
aria-label="Applications"
className={[styles.waffle, styles.waffleInteraction].join(' ')}
onClick={this._onOpenPopup}
>
<img src={'/images/suitenav/rs-waffle.svg'} />
<img src={'/images/suitenav/rs-waffle.svg'} alt="" />
</div>
<div className={styles.waffleDivider} />

Expand All @@ -106,7 +107,7 @@ class Root extends React.Component<React.PropsWithChildren<{}>> {
<a href="https://rushstack.io/community/events/" className={styles.suiteNavItem}>
Events
</a>
</div>
</nav>

{popupPane}

Expand Down