Runner: make MPI bind-to configurable#797
Open
alephpiece wants to merge 6 commits intomicrosoft:mainfrom
Open
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
polarG
requested changes
Apr 17, 2026
Contributor
polarG
left a comment
polarG
left a comment
There was a problem hiding this comment.
Overall: The feature is well-motivated and docs are solid, but the PR needs fixes before merge. See inline comments for details.
| # | Severity | Finding |
|---|---|---|
| 1 | BLOCKER | Existing MPI tests break — missing bind_to key on test mode dicts |
| 2 | SHOULD-FIX | No input validation on bind_to — injection risk + invalid values |
| 3 | SHOULD-FIX | No new tests for the bind_to feature |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
==========================================
+ Coverage 85.69% 85.70% +0.01%
==========================================
Files 103 103
Lines 7890 7897 +7
==========================================
+ Hits 6761 6768 +7
Misses 1129 1129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make MPI process binding configurable in SuperBench runner modes so benchmarks with their own topology-aware affinity logic can disable the default
-bind-to numabehavior when needed.Major Revision
bind_tofield formpimodes in the runnerbind_totonumabind_tovalue instead of a hard-codednuma