Port #62361: Make go-to-definition resolve constraint properties for object literals in argument positions#2746
Merged
jakebailey merged 10 commits intomainfrom Feb 13, 2026
Conversation
…d add self-reference check for go-to-definition on object literal properties Port of TypeScript PR #62361: Make go to definition go to the constraint's properties for object literals in argument positions. Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Port go to definition for constraint's properties in argument positions
Port #62361: Make go-to-definition resolve constraint properties for object literals in argument positions
Feb 11, 2026
Member
|
@copilot No tests got updated, so I don't think this is complete. Maybe some tests are fixed that are in failingTests? Look for the original tests modified in the PR you ported. |
…eNodeInferences for proper inference blocking, update baselines The self-reference check was correctly detecting when property declarations pointed back to the same object literal, but the retry with IgnoreNodeInferences was using the internal getApparentTypeOfContextualType which doesn't run through runWithInferenceBlockedFromSourceNode. Changed to use the public GetContextualType API which properly blocks inference from the source node, matching TypeScript's behavior. Baselines for goToDefinitionObjectLiteralProperties2 and goToDefinitionObjectLiteralProperties3 now match TypeScript's output exactly (diff files deleted). Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Contributor
Author
Fixed in 8141729. The self-reference detection was working, but the retry was using the internal |
jakebailey
reviewed
Feb 11, 2026
… helper functions Remove unnecessary wrapper functions (GetContextualDeclarationsForObjectLiteralElementWithNode, getContextualDeclarationsForObjectLiteralElementWorker, getDeclarationsFromContextualType, getDeclarationsFromType, hasSelfReferenceDeclaration) and put the logic directly in GetContextualDeclarationsForObjectLiteralElement with the added propertyNameNode parameter. Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Ports TypeScript PR #62361 into the Go-based TypeScript compiler/language server, improving go-to-definition behavior for object literal properties used as generic arguments by resolving to constraint property declarations (and aligning baseline outputs with upstream TypeScript).
Changes:
- Renames
ContextFlagsCompletionstoContextFlagsIgnoreNodeInferencesand updates all call sites to use the new flag. - Updates go-to-definition to detect self-referential object literal property definitions and re-run contextual typing with inference blocked to find constraint declarations.
- Updates fourslash go-to-definition baselines (and removes
.difffiles where Go output now matches TypeScript exactly).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/checker/types.go | Renames contextual typing flag and updates its documentation comment. |
| internal/checker/services.go | Implements inference-blocking behavior for the renamed flag and enhances contextual decl lookup for object literal elements. |
| internal/checker/jsx.go | Updates JSX contextual typing logic to use the renamed flag. |
| internal/ls/completions.go | Uses the renamed flag when requesting contextual types for completion scenarios. |
| internal/ls/string_completions.go | Uses the renamed flag for contextual-type-based string literal completions. |
| internal/ls/definition.go | Passes the property-name node through to contextual declaration lookup to support the new go-to-definition behavior. |
| testdata/baselines/reference/submodule/fourslash/goToDefinition/goToDefinitionObjectLiteralProperties2.baseline.jsonc | Baseline updated to reflect corrected go-to-definition targets. |
| testdata/baselines/reference/submodule/fourslash/goToDefinition/goToDefinitionObjectLiteralProperties2.baseline.jsonc.diff | Deleted because outputs now match the TypeScript reference. |
| testdata/baselines/reference/submodule/fourslash/goToDefinition/goToDefinitionObjectLiteralProperties3.baseline.jsonc | Baseline updated to reflect corrected go-to-definition targets. |
| testdata/baselines/reference/submodule/fourslash/goToDefinition/goToDefinitionObjectLiteralProperties3.baseline.jsonc.diff | Deleted because outputs now match the TypeScript reference. |
gabritto
reviewed
Feb 12, 2026
…lsFromContextualType Revert GetContextualDeclarationsForObjectLiteralElement to its original form. Move the self-reference detection logic from the checker to definition.go's getDeclarationsFromObjectLiteralElement, matching the TypeScript PR pattern: 1. Use GetContextualType (public API) to get the contextual type 2. Use GetPropertySymbolsFromContextualType to get property symbols (handles union discriminant filtering, deduplication, etc.) 3. Check if any property symbol's valueDeclaration self-references 4. If so, retry with ContextFlagsIgnoreNodeInferences 5. Call getDeclarationsFromObjectLiteralElement from the object literal property check path in getDeclarationsFromLocation Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Use else-if to avoid calling getDeclarationsFromObjectLiteralElement twice when the symbol is an object literal property. Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Remove GetContextualDeclarationsForObjectLiteralElement from checker/services.go as it has no equivalent in the original TypeScript code. Simplify getDeclarationsFromLocation to always call getDeclarationsFromObjectLiteralElement (matching TS's getDefinitionFromObjectLiteralElement), falling back to symbol.Declarations. This matches the TypeScript flow where getDefinitionFromObjectLiteralElement is called for all symbols. Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
gabritto
approved these changes
Feb 13, 2026
jakebailey
deleted the
copilot/port-go-to-definition-constraint-properties
branch
Copilot AI
added a commit
that referenced
this pull request
Feb 25, 2026
…object literals in argument positions (#2746) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContextFlagsCompletionstoContextFlagsIgnoreNodeInferencesin checker/types.godefinition.go, usingGetPropertySymbolsFromContextualTypeandGetContextualTypeto match the TypeScript PR pattern closelyGetContextualDeclarationsForObjectLiteralElementfrom checker — no equivalent in TS✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.