Merged
Conversation
Contributor
|
For optional targets, it is sometimes less intrusive to only control build and install instead of adding conditions everywhere. i.e. # not conditional; not modified
add_library(examples ...)
target_link_libraries(examples PRIVATE mainlib)
# only condition
if(EXAMPLES)
install(TARGETS examples ...)
else()
set_target_properties(examples PROPERTIES EXCLUDE_FROM_ALL 1)
endif() |
Contributor
Author
|
Thanks for the tip. Here I went with the proper way as I did the same in the upstream PR. |
Contributor
|
Usage test passed on x64-windows triplet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patches upstreamd here: BinomialLLC/basis_universal#383
./vcpkg x-add-version --alland committing the result.