Skip to content

fix: address npm audit security vulnerabilities#8602

Open
Copilot wants to merge 5 commits intomainfrom
copilot/fix-security-vulnerabilities
Open

fix: address npm audit security vulnerabilities#8602
Copilot wants to merge 5 commits intomainfrom
copilot/fix-security-vulnerabilities

Conversation

Copy link
Contributor

Copilot AI commented Mar 18, 2026

Summary

Addresses security vulnerabilities found by npm audit.

Changes

High severity (fixed)

  • serialize-javascript RCE (GHSA-5c6j-r48x-rmvq): Updated terser-webpack-plugin from 5.1.15.3.17 (direct dep fix). Added overrides entry to pin serialize-javascript to 7.0.4 for mocha's transitive dependency.
  • diff DoS (GHSA-73rr-hh4g-fpgx): Added overrides entry to pin diff to 8.0.3, fixing mocha's transitive dependency.

Low severity (mitigated)

  • elliptic risky crypto (GHSA-848j-6mx2-7j84): Added overrides entry to pin elliptic to 6.6.1 (latest). npm audit still reports this since the advisory marks all versions as vulnerable, but the GitHub Advisory Database confirms 6.6.1 is safe. The only npm-suggested fix would downgrade crypto-browserify from 3.12.03.3.0, which is a major breaking change.

Security Summary

  • All 3 high-severity vulnerabilities resolved
  • 4 low-severity issues (elliptic chain) mitigated by pinning to latest safe version per GitHub Advisory DB; cannot be fully eliminated without a breaking crypto-browserify downgrade

Copilot AI and others added 2 commits March 18, 2026 22:46
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
@rzhao271 rzhao271 added this to the 1.113.0 milestone Mar 18, 2026
@rzhao271 rzhao271 marked this pull request as ready for review March 18, 2026 22:53
Copilot AI review requested due to automatic review settings March 18, 2026 22:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses npm audit findings by updating a direct dependency and pinning several vulnerable transitive dependencies via npm overrides, alongside updating VS Code proposed API typings for chat session forking.

Changes:

  • Bumped terser-webpack-plugin to a patched version to address serialize-javascript vulnerability exposure.
  • Added npm overrides to pin diff, serialize-javascript, and elliptic to non-vulnerable versions.
  • Extended proposed VS Code API typings to support forking chat sessions via a new handler (and deprecated the older fork handler location).

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/@types/vscode.proposed.chatSessionsProvider.d.ts Adds/updates proposed API types for chat session forking and adjusts provider registration parameter naming/docs.
package.json Updates terser-webpack-plugin and introduces npm overrides for vulnerable transitive dependencies.
package-lock.json Regenerates lockfile to reflect the dependency bump and overrides-pinned transitive dependency graph.

You can also share your feedback on Copilot code review. Take the survey.

rzhao271 and others added 2 commits March 18, 2026 16:01
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@rzhao271 rzhao271 enabled auto-merge (squash) March 18, 2026 23:02
@rzhao271
Copy link
Contributor

@copilot Run npm i to update lockfile.

Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 18, 2026

@copilot Run npm i to update lockfile.

Done in a04c481.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants