Fix python.defaultInterpreterPath0. setting not being applied to new workspaces
#1110
+1
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StellaHuang95
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is a follow-up task to the sync meeting and the discussion in #861 (comment)
The PR fixes a bug where the
python.defaultInterpreterPathsetting was not being respected when opening new workspaces. Users who configured a specific Python interpreter path would see a different Python version selected instead.The root cause is that the early return prevented
api.setEnvironment()from ever being called, so the workspace environment was never actually set.When the extension later queried for the workspace environment, the
venvManager.get()method found nothing in the workspace-to-environment map and fell back toglobalEnv.Verified now the default is being used.
Also fixed wrong field used for
sysPrefix.