Skip to content

Add check to ensure vcpkg triplets match across projects #5950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florelis merged 7 commits into from
Jan 6, 2026
+66 −42
Merged

Add check to ensure vcpkg triplets match across projects #5950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8fe1db4
Add target to ensure triplet match
florelis Dec 30, 2025
37f3f7f
No ReleaseStatic for InProc testbed
florelis Dec 29, 2025
f8f115b
Add comments
florelis Dec 30, 2025
93557de
Make it work from VS
florelis Dec 30, 2025
5c14649
sp
florelis Dec 30, 2025
73341a4
Fix triplet for x86
florelis Jan 5, 2026
f334243
Update comment; delete file
florelis Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/AppInstallerCLI.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.2.32630.192
# Visual Studio Version 18
VisualStudioVersion = 18.0.11205.157
MinimumVisualStudioVersion = 10.0.40219.1
Project("{C7167F0D-BC9F-4E6E-AFE1-012C56B48DB5}") = "AppInstallerCLIPackage", "AppInstallerCLIPackage\AppInstallerCLIPackage.wapproj", "{6AA3791A-0713-4548-A357-87A323E7AC3A}"
ProjectSection(ProjectDependencies) = postProject
Expand Down Expand Up @@ -37,7 +37,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Project", "Project", "{8D53
..\azure-pipelines.nuget.yml = ..\azure-pipelines.nuget.yml
..\azure-pipelines.yml = ..\azure-pipelines.yml
..\cgmanifest.json = ..\cgmanifest.json
Directory.Build.props = Directory.Build.props
Get-VcxprojNugetPackageVersions.ps1 = Get-VcxprojNugetPackageVersions.ps1
..\README.md = ..\README.md
..\doc\ReleaseNotes.md = ..\doc\ReleaseNotes.md
Expand Down Expand Up @@ -97,7 +96,9 @@ EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{1A5D7A7D-5CB2-47D5-B40D-4E61CAEDC798}"
ProjectSection(SolutionItems) = preProject
CodeAnalysis.ruleset = CodeAnalysis.ruleset
Directory.Build.props = Directory.Build.props
Directory.Packages.props = Directory.Packages.props
Directory.Solution.props = Directory.Solution.props
nuget.config = nuget.config
stylecop.json = stylecop.json
vcpkg.json = vcpkg.json
Expand Down Expand Up @@ -1043,11 +1044,8 @@ Global
{E5BCFF58-7D0C-4770-ABB9-AECE1027CD94}.Release|x86.ActiveCfg = Release|Win32
{E5BCFF58-7D0C-4770-ABB9-AECE1027CD94}.Release|x86.Build.0 = Release|Win32
{E5BCFF58-7D0C-4770-ABB9-AECE1027CD94}.ReleaseStatic|ARM64.ActiveCfg = Release|ARM64
{E5BCFF58-7D0C-4770-ABB9-AECE1027CD94}.ReleaseStatic|ARM64.Build.0 = Release|ARM64
{E5BCFF58-7D0C-4770-ABB9-AECE1027CD94}.ReleaseStatic|x64.ActiveCfg = Release|x64
{E5BCFF58-7D0C-4770-ABB9-AECE1027CD94}.ReleaseStatic|x64.Build.0 = Release|x64
{E5BCFF58-7D0C-4770-ABB9-AECE1027CD94}.ReleaseStatic|x86.ActiveCfg = Release|Win32
{E5BCFF58-7D0C-4770-ABB9-AECE1027CD94}.ReleaseStatic|x86.Build.0 = Release|Win32
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down
4 changes: 4 additions & 0 deletions src/Directory.Solution.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<!-- This file is automatically included in the (autogenerated) project file for the solution. -->
<Project>
<Import Project="$(MSBuildProjectDirectory)\vcpkg.props" />
</Project>
94 changes: 58 additions & 36 deletions src/vcpkg.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,50 +2,72 @@
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup Label="Vcpkg">
<VcpkgEnableManifest>true</VcpkgEnableManifest>
<VcpkgInstalledDir>$(MSBuildThisFileDirectory)\vcpkg_installed</VcpkgInstalledDir>
<VcpkgInstalledDir>$(MSBuildThisFileDirectory)vcpkg_installed\</VcpkgInstalledDir>
<!-- Note: For x86, the platform is x86 when building the solution meta-project, and Win32 when building individual projects. -->
<_VcpkgTripletPlatform>$(Platform)</_VcpkgTripletPlatform>
<_VcpkgTripletPlatform Condition="'$(Platform)'=='Win32'">x86</_VcpkgTripletPlatform>
</PropertyGroup>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<VcpkgTriplet>x64</VcpkgTriplet>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)'=='Debug'">
<VcpkgTriplet>$(_VcpkgTripletPlatform)</VcpkgTriplet>
<VcpkgConfiguration>Debug</VcpkgConfiguration>
</PropertyGroup>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">
<VcpkgTriplet>arm64</VcpkgTriplet>
<VcpkgConfiguration>Debug</VcpkgConfiguration>
</PropertyGroup>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
<VcpkgTriplet>x86</VcpkgTriplet>
<VcpkgConfiguration>Debug</VcpkgConfiguration>
</PropertyGroup>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<VcpkgTriplet>x64-release</VcpkgTriplet>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)'=='Release'">
<VcpkgTriplet>$(_VcpkgTripletPlatform)-release</VcpkgTriplet>
<VcpkgConfiguration>Release</VcpkgConfiguration>
</PropertyGroup>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">
<VcpkgTriplet>arm64-release</VcpkgTriplet>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)'=='ReleaseStatic'">
<VcpkgTriplet>$(_VcpkgTripletPlatform)-release-static</VcpkgTriplet>
<VcpkgConfiguration>Release</VcpkgConfiguration>
</PropertyGroup>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
<VcpkgTriplet>x86-release</VcpkgTriplet>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)'=='Fuzzing'">
<VcpkgTriplet>$(_VcpkgTripletPlatform)-fuzzing</VcpkgTriplet>
<VcpkgConfiguration>Release</VcpkgConfiguration>
</PropertyGroup>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)|$(Platform)'=='ReleaseStatic|x64'">
<VcpkgTriplet>x64-release-static</VcpkgTriplet>
<VcpkgConfiguration>Release</VcpkgConfiguration>
</PropertyGroup>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)|$(Platform)'=='ReleaseStatic|ARM64'">
<VcpkgTriplet>arm64-release-static</VcpkgTriplet>
<VcpkgConfiguration>Release</VcpkgConfiguration>
</PropertyGroup>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)|$(Platform)'=='ReleaseStatic|Win32'">
<VcpkgTriplet>x86-release-static</VcpkgTriplet>
<VcpkgConfiguration>Release</VcpkgConfiguration>
</PropertyGroup>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)|$(Platform)'=='Fuzzing|x64'">
<VcpkgTriplet>x64-fuzzing</VcpkgTriplet>
<VcpkgConfiguration>Release</VcpkgConfiguration>
</PropertyGroup>
<PropertyGroup Label="Vcpkg" Condition="'$(Configuration)|$(Platform)'=='Fuzzing|Win32'">
<VcpkgTriplet>x86-fuzzing</VcpkgTriplet>
<VcpkgConfiguration>Release</VcpkgConfiguration>

<!-- vcpkg can only install ports for one triplet at a time, so we need to ensure that every project using vcpkg uses the same triplet.
If there is a triplet mismatch, the ports for one of the triplets will be deleted when installing a second one.
In parallel builds, this can lead to projects that use the first triplet not being able to find the headers or binaries, and cause an error. -->

<PropertyGroup>
<!-- The MSBuild process starts with the solution file, and each individual project is built recursively from there.
When building the .sln, we will write a file to indicate which triplet should be used in all projects.
Each project will later read this file to verify that it is using the same triplet. -->
<_IsBuildingSln>$(MSBuildProjectName.EndsWith('.sln'))</_IsBuildingSln>
<_TripletFile>$(VcpkgInstalledDir).solution-triplet</_TripletFile>
</PropertyGroup>

<Target Name="WriteSolutionTripletToFile"
BeforeTargets="Build"
Condition="'$(_IsBuildingSln)' == 'true'">
<WriteLinesToFile File="$(_TripletFile)" Lines="$(VcpkgTriplet)" Overwrite="true" />
</Target>

<!-- Note: Visual Studio does not build the .sln in the same way that MSBuild.exe does.
VS builds each project directly, instead of calling MSBuild on the .sln.
This means that in VS the file is not written in the previous task, so we try to write it on the first project we build.
There is a race condition for parallel builds in doing this, but it is unlikely and it cannot happen in pipeline (official) builds. -->
<Target Name="WriteProjectTripletToFile"
BeforeTargets="EnsureNoTripletMismatch"
Condition="!Exists('$(_TripletFile)')">
<WriteLinesToFile File="$(_TripletFile)" Lines="$(VcpkgTriplet)" Overwrite="true" />
</Target>

<Target Name="EnsureNoTripletMismatch"
BeforeTargets="PrepareForBuild"
Condition="'$(_IsBuildingSln)' != 'true'" >

<ReadLinesFromFile File="$(_TripletFile)">
<Output TaskParameter="Lines" ItemName="_TripletFileLines" />
</ReadLinesFromFile>

<PropertyGroup>
<_SolutionTriplet>@(_TripletFileLines)</_SolutionTriplet>
</PropertyGroup>

<!-- For the dev inner loop using VS, this target will fail any time we build with a different configuration.
We delete the file so that the next build works fine. -->
<Delete Condition=" '$(_SolutionTriplet)' != '$(VcpkgTriplet)' " Files="$(_TripletFile)" />
<Error Condition=" '$(_SolutionTriplet)' != '$(VcpkgTriplet)' "
Text="The vcpkg triplet '$(VcpkgTriplet)' selected for project '$(MSBuildProjectName)' does not match the recorded triplet '$(_SolutionTriplet)'. This may indicate a mismatch in the triplets used for current build configuration. If you have just changed the Configuration in Visual Studio, this error may be spurious and building again should properly check for mismatch." />
</Target>
</Project>