Add settings section for clearing browser history#1738
Open
JayKid wants to merge 2 commits intominbrowser:masterfrom
Open
Add settings section for clearing browser history#1738JayKid wants to merge 2 commits intominbrowser:masterfrom
JayKid wants to merge 2 commits intominbrowser:masterfrom
Conversation
Minimal version of the settings pane to clear browsing history. Sadly, the functionality is not there: 1. First attempt was to use `places.deleteAllHistory()` but it's not available in this scope and I can't use require/import to fetch it 2. Tried using directly postMessage as places internally does but that postMessage within places is directed to the particular worker so this didn't work either Also used inline styles which should be migrated to some stylesheet, but just wanted to put a quick PoC together to ask for pointers when it comes to actually clearing the DB of its stored URLs.
Collaborator
|
The right way to do this would be postMessage to the preload script -> send an IPC from there (like this) -> have an IPC listener in the UI process that calls places.deleteHistory(). But I'm not sure that's really the right solution anyway - there's a "clear all history" button in the history view already. So I think what we want is just the "clear history on closing the browser" part. For that, you'd need two things:
But thinking about this more (and I'm thinking and writing this at the same time), I wonder if "clear history on quit" is really the right behavior:
So another, possibly better, way we could do this would be:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minimal version of the settings pane to clear browsing history.
Sadly, the functionality is not there:
First attempt was to use
places.deleteAllHistory()but it's not available in this scope and I can't use require/import to fetch itTried using directly postMessage as places internally does but that postMessage within places is directed to the particular worker so this didn't work either
Also, I used inline styles which should be migrated to some stylesheet, but just wanted to put a quick PoC together to ask for pointers when it comes to actually clearing the DB of its stored URLs.
New settings section