Skip to content

MOBILEWEBVIEW-31: support featureToggle section in config#672

Merged
sergeysozinov merged 3 commits intomission/webview-inappfrom
feature/MOBILEWEBVIEW-31
Feb 4, 2026
Merged

MOBILEWEBVIEW-31: support featureToggle section in config#672
sergeysozinov merged 3 commits intomission/webview-inappfrom
feature/MOBILEWEBVIEW-31

Conversation

@sergeysozinov
Copy link
Collaborator

@sergeysozinov sergeysozinov requested a review from Copilot February 3, 2026 15:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements support for a featureToggles section in the configuration, specifically adding a shouldSendInAppShowError toggle. The implementation includes parsing logic with robust error handling, state management, and comprehensive test coverage.

Changes:

  • Added FeatureTogglesDto and FeatureTogglesDtoBlank data classes to represent feature toggle configuration
  • Implemented FeatureToggleManager to manage toggle state with thread-safe storage
  • Integrated feature toggle parsing and application into the configuration flow with fallback to false for invalid values

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
InAppConfigResponse.kt Added FeatureTogglesDto data classes to configuration models
FeatureToggleManager.kt Defined interface and enum for feature toggle management
FeatureToggleManagerImpl.kt Implemented thread-safe feature toggle state management
FeatureTogglesDtoBlankDeserializer.kt Created custom deserializer with strict boolean type validation
JsonElementExtensions.kt Added helper function for safe boolean extraction from JSON
MobileConfigRepositoryImpl.kt Integrated feature toggle parsing and application into config flow
MobileConfigSerializationManagerImpl.kt Added featureToggles parsing to settings deserialization
InAppMessageViewDisplayerImpl.kt Added logging for feature toggle state
DataModule.kt Registered FeatureToggleManager in dependency injection
PresentationModule.kt Updated InAppMessageViewDisplayerImpl instantiation with FeatureToggleManager
Test files Added comprehensive tests for feature toggle functionality and error handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sergeysozinov sergeysozinov requested a review from enotniy February 4, 2026 06:36
@sergeysozinov sergeysozinov requested a review from enotniy February 4, 2026 11:47
@sergeysozinov sergeysozinov merged commit e1412f8 into mission/webview-inapp Feb 4, 2026
5 checks passed
@sergeysozinov sergeysozinov deleted the feature/MOBILEWEBVIEW-31 branch February 4, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants