MOBILEWEBVIEW-31: support featureToggle section in config#672
Merged
sergeysozinov merged 3 commits intomission/webview-inappfrom Feb 4, 2026
Merged
MOBILEWEBVIEW-31: support featureToggle section in config#672sergeysozinov merged 3 commits intomission/webview-inappfrom
sergeysozinov merged 3 commits intomission/webview-inappfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements support for a featureToggles section in the configuration, specifically adding a shouldSendInAppShowError toggle. The implementation includes parsing logic with robust error handling, state management, and comprehensive test coverage.
Changes:
- Added
FeatureTogglesDtoandFeatureTogglesDtoBlankdata classes to represent feature toggle configuration - Implemented
FeatureToggleManagerto manage toggle state with thread-safe storage - Integrated feature toggle parsing and application into the configuration flow with fallback to
falsefor invalid values
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| InAppConfigResponse.kt | Added FeatureTogglesDto data classes to configuration models |
| FeatureToggleManager.kt | Defined interface and enum for feature toggle management |
| FeatureToggleManagerImpl.kt | Implemented thread-safe feature toggle state management |
| FeatureTogglesDtoBlankDeserializer.kt | Created custom deserializer with strict boolean type validation |
| JsonElementExtensions.kt | Added helper function for safe boolean extraction from JSON |
| MobileConfigRepositoryImpl.kt | Integrated feature toggle parsing and application into config flow |
| MobileConfigSerializationManagerImpl.kt | Added featureToggles parsing to settings deserialization |
| InAppMessageViewDisplayerImpl.kt | Added logging for feature toggle state |
| DataModule.kt | Registered FeatureToggleManager in dependency injection |
| PresentationModule.kt | Updated InAppMessageViewDisplayerImpl instantiation with FeatureToggleManager |
| Test files | Added comprehensive tests for feature toggle functionality and error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...in/java/cloud/mindbox/mobile_sdk/inapp/data/managers/MobileConfigSerializationManagerImpl.kt
Show resolved
Hide resolved
...in/java/cloud/mindbox/mobile_sdk/inapp/data/managers/MobileConfigSerializationManagerImpl.kt
Show resolved
Hide resolved
enotniy
approved these changes
Feb 4, 2026
sdk/src/main/java/cloud/mindbox/mobile_sdk/models/operation/response/InAppConfigResponse.kt
Outdated
Show resolved
Hide resolved
...src/main/java/cloud/mindbox/mobile_sdk/inapp/data/repositories/MobileConfigRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
enotniy
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILEWEBVIEW-31