Fix inconsistent package naming by forcing lowercase in SuggestClassNamePropertyDerivation#2620
Open
destroydevs wants to merge 1 commit intominecraft-dev:devfrom
Open
Fix inconsistent package naming by forcing lowercase in SuggestClassNamePropertyDerivation#2620destroydevs wants to merge 1 commit intominecraft-dev:devfrom
destroydevs wants to merge 1 commit intominecraft-dev:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
SuggestClassNamePropertyDerivationclass usesdecapitalize()when generating the package part of the Main Class FQN. This leads tocamelCasenaming (e.g.,com.example.myProject), which violates standard Java/Kotlin package naming conventions.Changes
.decapitalize()with.lowercase()for the artifact/name segment of the package path..lowercase()tocoords.groupIdto ensure the entire package path remains standard-compliant.Motivation
Java packages should always be lowercase. While the "Old Wizard" handled this correctly, the new Custom Wizard logic was preserving upper-case characters from the project name/artifact ID. This change aligns the custom wizard with professional development standards and the behavior seen in the Mod creation templates.