Optimized write adapters and improved code clarity#940
Merged
michelebastione merged 5 commits intomini-software:masterfrom Apr 3, 2026
Merged
Optimized write adapters and improved code clarity#940michelebastione merged 5 commits intomini-software:masterfrom
michelebastione merged 5 commits intomini-software:masterfrom
Conversation
…r methods and reduce code clutter
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors internal row processing by replacing nested IEnumerables with arrays and optimizing list allocations. It renames property-related variables to 'mappings' for consistency, updates template context properties to PascalCase, and adds a NetStandard2.0 compatibility extension for GetValueOrDefault. Feedback was provided to correct a minor formatting issue in the new extension method.
Signed-off-by: Michele Bastione <michele.bastione@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IEnumerable<CellWriteInfo>toCellWriteInfo[]for all write adapters as having to callMoveNextfor each cell is mostly not worth the overhead costNetStandardExtensionsclass to replicate .NET framework's helper methods and improve code clarity