Skip to content

Enhanced OpenXmlImporter with new functionality for retrieving comments and notes#941

Merged
michelebastione merged 11 commits intomini-software:masterfrom
michelebastione:retrieving-comments
Apr 4, 2026
Merged

Enhanced OpenXmlImporter with new functionality for retrieving comments and notes#941
michelebastione merged 11 commits intomini-software:masterfrom
michelebastione:retrieving-comments

Conversation

@michelebastione
Copy link
Copy Markdown
Contributor

@michelebastione michelebastione commented Apr 3, 2026

New comment retrieval API

This PR adds support for retrieving both threaded comments and legacy notes from Excel worksheets through the new RetrieveComments and RetrieveCommentsAsync methods in the OpenXmlImporter class, and thus closes #440.

Extracted comment data includes:

  • Cell address
  • Author information (name and provider id)
  • Creation timestamp
  • Comment text
  • Nested replies with their own metadata

Extracted note data includes:

  • Cell address
  • Author name (if available)
  • Note text

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements functionality to retrieve threaded comments and legacy notes from Excel files, adding new models and updating the OpenXmlReader and OpenXmlImporter. It also enhances stream management for modern .NET versions and standardizes namespace constants. Review feedback suggests several improvements for robustness and performance, including safer null handling for paths, culture-invariant date parsing, more efficient file entry lookups, and better handling of legacy comment attributes and text nodes.

@michelebastione michelebastione merged commit 2a2c32a into mini-software:master Apr 4, 2026
3 checks passed
@michelebastione michelebastione deleted the retrieving-comments branch April 4, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding support for retrieving comments and notes from spreadsheet

1 participant