Enhanced OpenXmlImporter with new functionality for retrieving comments and notes#941
Merged
michelebastione merged 11 commits intomini-software:masterfrom Apr 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements functionality to retrieve threaded comments and legacy notes from Excel files, adding new models and updating the OpenXmlReader and OpenXmlImporter. It also enhances stream management for modern .NET versions and standardizes namespace constants. Review feedback suggests several improvements for robustness and performance, including safer null handling for paths, culture-invariant date parsing, more efficient file entry lookups, and better handling of legacy comment attributes and text nodes.
a239e2a to
1b61704
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New comment retrieval API
This PR adds support for retrieving both threaded comments and legacy notes from Excel worksheets through the new
RetrieveCommentsandRetrieveCommentsAsyncmethods in the OpenXmlImporter class, and thus closes #440.Extracted comment data includes:
Extracted note data includes: