Fix: share bufio.Scanner across ExecuteCommand calls#72
Merged
mirkoboehm merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
bufio.NewScanner wraps the stdout pipe in an internal 4096-byte read-ahead buffer. Creating a new Scanner on each ExecuteCommand call discards any bytes already buffered from the previous call, causing the next command's BEGIN_MARKER to be lost and the goroutine to block indefinitely waiting for output that was already consumed. Fix by creating the Scanner once in StartShell and reusing it for the lifetime of the shell process. Closes #71
mirkoboehm
force-pushed
the
wip/mirko-71-ExecuteCommand-hangs
branch
from
efe6dfa to
3c2c9c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bufio.NewScanner wraps the stdout pipe in an internal 4096-byte read-ahead buffer. Creating a new Scanner on each ExecuteCommand call discards any bytes already buffered from the previous call, causing the next command's BEGIN_MARKER to be lost and the goroutine to block indefinitely waiting for output that was already consumed.
Fix by creating the Scanner once in StartShell and reusing it for the lifetime of the shell process.