Open
Conversation
Reusable workflows are a new feature [1] that allow a workflow to be dispatched from another workflow. Using reusable workflows involves creating a job with a `uses` key and no `steps` key [2]. This change allows these jobs to pass silently through actions-includes instead of causing a failure. [1] https://github.blog/2021-11-29-github-actions-reusable-workflows-is-generally-available/ [2] https://docs.github.com/en/actions/learn-github-actions/reusing-workflows#calling-a-reusable-workflow
mithro
approved these changes
Jan 19, 2022
Owner
mithro
left a comment
mithro
left a comment
There was a problem hiding this comment.
It would be a nice to have a test, but I can merge without it.
Author
|
Thanks! Happy to test this; is a doctest on the changed functions what you're looking for or is there something else that would be useful? I couldn't immediately figure out how the files in /tests are used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusable workflows are a new feature [1] that allow a workflow to be dispatched from another workflow.
Using reusable workflows involves creating a job with a
useskey and nostepskey [2].This change allows these jobs to pass silently through actions-includes instead of causing a failure.
[1] https://github.blog/2021-11-29-github-actions-reusable-workflows-is-generally-available/
[2] https://docs.github.com/en/actions/learn-github-actions/reusing-workflows#calling-a-reusable-workflow