chore(deps): update akhileshns/heroku-deploy digest to e3eb99d - autoclosed#5409
Closed
renovate[bot] wants to merge 1 commit intomasterfrom
Closed
chore(deps): update akhileshns/heroku-deploy digest to e3eb99d - autoclosed#5409renovate[bot] wants to merge 1 commit intomasterfrom
renovate[bot] wants to merge 1 commit intomasterfrom
Conversation
4d0996b to
2698088
Compare
72e44d1 to
bdb29d8
Compare
bdb29d8 to
7369847
Compare
7369847 to
4f421ca
Compare
4f421ca to
36eb45b
Compare
36eb45b to
0fd98be
Compare
0fd98be to
26ce9ad
Compare
26ce9ad to
8e9485d
Compare
c0c3b7d to
5f56a47
Compare
19d44b4 to
c52a886
Compare
c52a886 to
fadf9a0
Compare
fadf9a0 to
3f19446
Compare
a5496d6 to
233c79e
Compare
19008fb to
b820827
Compare
| with: | ||
| ref: release | ||
| - uses: akhileshns/heroku-deploy@79ef2ae4ff9b897010907016b268fd0f88561820 | ||
| - uses: akhileshns/heroku-deploy@e3eb99d45a8e2ec5dca08735e089607befa4bf28 |
There was a problem hiding this comment.
Bug: The deployment workflow will fail because ubuntu-latest no longer includes the Heroku CLI, which the heroku-deploy action requires.
Severity: CRITICAL
Suggested Fix
Add a step to the workflow before the deploy action to manually install the Heroku CLI. For example: - name: Install Heroku CLI run: curl https://cli-assets.heroku.com/install.sh | sh. Alternatively, pin the runner to ubuntu-22.04.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/production.yml#L21
Potential issue: The deployment workflow is configured to run on `ubuntu-latest`. As of
early 2025, this runner image defaults to Ubuntu 24.04, which no longer has the Heroku
CLI pre-installed. The `akhileshns/heroku-deploy` action requires the Heroku CLI to
function, but the workflow lacks a step to install it. Consequently, any attempt to run
this workflow will result in a failure during the deployment step, as the necessary CLI
tool will be missing. This will prevent all deployments from completing successfully.
Did we get this right? 👍 / 👎 to inform future reviews.
0f7b051 to
0040b60
Compare
0040b60 to
287a0a9
Compare
8e730ac to
0365f2c
Compare
4c146fc to
7e1b62e
Compare
7e1b62e to
1d506a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
79ef2ae→e3eb99dConfiguration
📅 Schedule: Branch creation - "every weekend" in timezone US/Eastern, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.