Conversation
… available for the course
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
n/a
Description (What does it do?)
The Learn frontend uses the
certificate_typefield to determine what badge to display for the certificate for a given course. However, this doesn't work quite right if the course doesn't have a certificate, so this PR adds in a separate field that can be used to determine whether or not to display the badge.How can this be tested?
Automated tests should pass.
The
certificate_availablefield should be True if the next run has a certificate available. So, this can be tested by setting and clearing thecertificate_available_dateon the next run for a given course - if there is one, then it should be True and vice versa.Additional Context
This uses the
first_unexpired_runcomputed property, which the serializer uses elsewhere too, so it shouldn't incur any additional database overhead. The limitation of this is that if the next run doesn't have a cert, but a future one does, then we won't display the badge. Not sure if that's OK or if it should consider any future run instead.