Skip to content

2350 introduce shortcutkey component#2373

Open
Lisa18289 wants to merge 6 commits intomainfrom
2350-introduce-shortcutkey-component
Open

2350 introduce shortcutkey component#2373
Lisa18289 wants to merge 6 commits intomainfrom
2350-introduce-shortcutkey-component

Conversation

@Lisa18289
Copy link
Member

No description provided.

@Lisa18289 Lisa18289 self-assigned this Mar 10, 2026
@Lisa18289 Lisa18289 linked an issue Mar 10, 2026 that may be closed by this pull request
@Lisa18289 Lisa18289 added the update-screenshots Label a PR to update the screenshots used for visual regression testing label Mar 10, 2026
@github-actions github-actions bot removed the update-screenshots Label a PR to update the screenshots used for visual regression testing label Mar 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 82.24% 264 / 321
🔵 Statements 82.56% 270 / 327
🔵 Functions 89.85% 62 / 69
🔵 Branches 71.34% 122 / 171
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/components/src/components/propTypes/index.ts 100% 100% 100% 100%
Generated in workflow #4846 for commit 9b47473 by the Vitest Coverage Report Action

@Lisa18289 Lisa18289 added the update-screenshots Label a PR to update the screenshots used for visual regression testing label Mar 10, 2026
@github-actions github-actions bot removed the update-screenshots Label a PR to update the screenshots used for visual regression testing label Mar 10, 2026
github-actions bot and others added 3 commits March 10, 2026 11:00
Co-authored-by: Lisa18289 <84317589+Lisa18289@users.noreply.github.com>
…nent' into 2350-introduce-shortcutkey-component

const stringFormatter = useLocalizedStringFormatter(locales);

const isMac = navigator.userAgent.includes("Mac");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this into components/lib/isMac.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce ShortcutKey Component

2 participants