Update Expo Example and fix more FF JS issues #345
+894
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve Mixpanel network request handling by: - Adding support for GET and POST requests - Implementing different error handling for GET/POST - Refining retry logic based on request type - Improving logging and error reporting - Ensuring more robust network communication
Enable Feature Flags during Mixpanel initialization and add a new "Feature Flags" section with buttons that exercise the Flags API (loadFlags, check ready, sync/async getVariant, getVariantValue, isEnabled). This brings the MixpanelExpo sample in line with the MixpanelStarter app so QA can manually test Feature Flags behavior in the Expo sample app.
Allow enabling Mixpanel JavaScript-mode feature flags through an environment variable to avoid the runtime error about flags only being available in native mode. Add a .env file with MIXPANEL_ENABLE_JS_FLAGS and MIXPANEL_TOKEN for local testing, and configure babel to load .env values via react-native-dotenv so the env variables are available in JS.
Initialize Mixpanel in a useEffect with the MIXPANEL_TOKEN from .env and show a loading state until initialization completes. This fixes the "Failed to load flags: Feature flags are not initialized" error by ensuring feature flags are enabled only after the SDK has been initialized. Also switch to a ref-based Mixpanel instance, enable logging, and add a simple ActivityIndicator UI while initializing. Changes: - Load MIXPANEL_TOKEN from .env and update .env sample. - Initialize Mixpanel asynchronously in useEffect and enable feature flags. - Store Mixpanel instance in useRef and gate UI on initialization with ActivityIndicator. - Minor style updates for loading layout.
Fix initialization error "Feature flags are not initialized" when clicking "Load Flags" by supplying AsyncStorage to the Mixpanel constructor. This enables JavaScript-mode feature flags support so flags are properly initialized and can be loaded. Changes: - Import AsyncStorage from @react-native-async-storage/async-storage. - Pass AsyncStorage as the fourth argument to new Mixpanel(...) when creating the instance. - Leave feature-flag enabling call (mp.init) intact; this change provides the storage dependency needed for it to work.
Allow custom headers and correct URL query concatenation in network layer to support authenticated flag requests and avoid malformed URLs. This adds an optional headers parameter to sendRequest, merges headers into POST requests and includes them for GET requests, and chooses '?' or '&' depending on existing query params. These changes enable sending Authorization (Basic) headers for the /flags endpoint (fixing CORS/401 issues) and ensure ip query is appended correctly.
Return the Promise from initializationCompletePromise so callers can await initialization. Previously the function created a Promise.all but did not return it, meaning callers couldn't know when identity, super properties and time events had finished loading. This change fixes that by returning Promise.all([...]) so the initialization flow can be awaited and errors propagated.
Provide a cross-platform UUID v4 generator to avoid requiring the uuid module in environments where it may be unavailable (fixes "Could not generate traceparent (UUID unavailable): Requiring unknown module \"undefined\"" errors). The change adds generateUUID() which tries the uuid package, then the Web Crypto API (crypto.randomUUID), and finally a Math.random-based fallback, and uses it when creating device IDs in MixpanelPersistent.
Upgrade AsyncStorage to latest version, add react-native-dotenv for environment variable management, and update package-lock.json with corresponding dependency changes.
jaredmixpanel
changed the base branch from
master
to
feature/add-feature-flags-support
jaredmixpanel
force-pushed
the
feature/add-feature-flags-support
branch
from
39b5a73 to
1ac86a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes