Fetch nanobind with cmake #2949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awni
reviewed
Dec 23, 2025
CMakeLists.txt
Outdated
| option(MLX_BUILD_GGUF "Include support for GGUF format" ON) | ||
| option(MLX_BUILD_SAFETENSORS "Include support for safetensors format" ON) | ||
| option(MLX_BUILD_BLAS_FROM_SOURCE "Build OpenBLAS from source code" OFF) | ||
| option(MLX_BUILD_STUBS "Build stub files for python bindings" ON) |
Member
There was a problem hiding this comment.
I might rename that MLX_BUILD_PYTHON_STUBS just to make it a little more clear it's specific to Python.
Also we could just always build the stubs.. since it defaults to on seems unlikely anyone will ever turn it off.
Collaborator
Author
There was a problem hiding this comment.
Building stubs requires the binary to be runnable, so for arm64 build on CI we have to disable stubs.
awni
approved these changes
Dec 23, 2025
Member
awni
left a comment
awni
left a comment
There was a problem hiding this comment.
Looks like a great change. I left a minor comment. Feel free to merge when ready!
zcbenz
force-pushed
the
vendor-nanobind
branch
from
37f13cf to
4c0e2ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a build isolation v.s.
ccachething: with build isolation the python packages (i.e.nanobind) and cmake build dir would be put under different temporary dirs, andccachewould not able to cache files usingnanobindbecause the they are including headers from a temporary dir. That's why we use--no-build-isolationto fix cache misses, and also why we always have cache misses when using uv because it always builds things in temporary dir.There are also other benefits:
nanobind==2.10.2in a lot of places.--no-build-isolation.