Consolidate logging for DLIOBenchmark initialization and data generation#8
Merged
FileSystemGuy merged 1 commit intomlcommons:mainfrom Apr 7, 2026
Conversation
russfellows
approved these changes
Apr 2, 2026
russfellows
left a comment
russfellows
left a comment
There was a problem hiding this comment.
I think these all look good. Agree we should be consistent with "self.logger" rather than print.
idevasena
approved these changes
Apr 2, 2026
FileSystemGuy
approved these changes
Apr 2, 2026
wolfgang-desalvador
force-pushed
the
wdesalvador/consolidate-logging-on-rank-0
branch
from
3115892 to
6337267
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how debug and warning messages are handled in the initialization and configuration of the DLIO benchmark. It replaces direct
printstatements with structured logging, ensures that debug output is only shown on the main process (rank 0), and clarifies the logic for selecting the data generation method.Logging improvements:
printstatements indlio_benchmark/main.pywith calls to theDLIOLoggerfor consistent and centralized logging. Debug output is now only emitted by the main process (rank 0), reducing noise in multi-process runs. [1] [2]Configuration logic and warnings:
dlio_benchmark/utils/config.py, ensures that if the preferred data generation method is not available, it falls back to'numpy'and logs a warning only from the main process. This prevents repeated warnings in multi-process scenarios and clarifies when and why the fallback occurs. [1] [2]…ion method