Fix: DirectML device enumeration fails with --temp-dir option#13
Open
ssam18 wants to merge 1 commit intomlcommons:mainfrom
Open
Fix: DirectML device enumeration fails with --temp-dir option#13ssam18 wants to merge 1 commit intomlcommons:mainfrom
ssam18 wants to merge 1 commit intomlcommons:mainfrom
Conversation
Fixes mlcommons#8 When --temp-dir is set to current directory (.), the DirectML/DXCore device enumeration would fail because AddDllDirectory() returns an invalid handle. This caused device enumeration to return empty list, making even device ID 0 invalid and preventing benchmark initialization.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Contributor
|
@mrxmartino to copy into dev repo and include in the next 1.6 RC build. |
Contributor
|
The Client working group is considering pulling this PR into its new builds. Thanks. |
Author
|
Thank you for the update. |
Author
|
@mrxmartino - Please let me know if this PR is merged. |
Contributor
|
@ssam18 It was merged, but during our internal testing, we found issues with device enumeration, inconsistent behaviour, or missing configurations in the GUI builds. The PR was reverted. We will revisit this PR after a new build. Let's keep this open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8
When
--temp-diris set to current directory (), the DirectML/DXCore device enumeration would fail becauseAddDllDirectory()returns an invalid handle when called with the current directory. This caused device enumeration to return an empty list, making even device ID 0 invalid and preventing benchmark initialization on NVIDIA RTX 5060 Laptop GPU and AMD Radeon 880M.