Fixing a bug that will allow a value of '0' to bypass validation.#1
Open
leadoux wants to merge 1 commit intommirus:masterfrom
Open
Fixing a bug that will allow a value of '0' to bypass validation.#1leadoux wants to merge 1 commit intommirus:masterfrom
leadoux wants to merge 1 commit intommirus:masterfrom
Conversation
mmirus
reviewed
Dec 1, 2020
| public function validate($result, $value, $form, $field) { | ||
| // if validation has passed so far, and regex validation is enabled, and a pattern was provided, and a value was provided | ||
| if ($result['is_valid'] && $field['regexValidation'] && !empty($field['regexPattern']) && !empty($value)) { | ||
| if ($result['is_valid'] && $field['regexValidation'] && !empty($field['regexPattern']) && ( strlen($value) != 0 )) { |
Owner
There was a problem hiding this comment.
Good suggestion @leadoux! This is a little cleaner, and should work as well--look good to you?
Suggested change
| if ($result['is_valid'] && $field['regexValidation'] && !empty($field['regexPattern']) && ( strlen($value) != 0 )) { | |
| if ($result['is_valid'] && $field['regexValidation'] && !empty($field['regexPattern']) && strlen($value)) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Matt.
We use your gravityforms-regex-validation plugin - thanks.
I have found a small bug where a value of 0 will not pass as True for
!empty($value), and then regex validation does not happen, allowing '0' to pass strait past the regex - obviously not a desireable outcome.Please reveiw my simple fix and consider rolling it into your code to fix this issue for all.
Regards...Adam.