Skip to content

Conversation

@skjerns
Copy link
Contributor

@skjerns skjerns commented Jan 14, 2026

fixes #13581

I've added some more information on eSSS and how to apply it. I'm far from an expert in SSS, so please let me know if my wording is correct.

Additional information

I think it might also be nice to have a full workflow in the example section that applys teSSS, together with head movement correction. Is there a dataset which would be used for that? Else we could record a small dataset for this purpose and upload it somewhere.

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor commits, I'll push and then merge when green, thanks @skjerns !

@larsoner
Copy link
Member

Oh I just saw draft and main comments, so I won't mark for merge

I think it might also be nice to have a full workflow in the example section that applys teSSS, together with head movement correction. Is there a dataset which would be used for that? Else we could record a small dataset for this purpose and upload it somewhere.

skjerns and others added 2 commits January 14, 2026 17:37
Added external example link for teSSS with movement compensation.
@skjerns
Copy link
Contributor Author

skjerns commented Jan 14, 2026

Oh I just saw draft and main comments, so I won't mark for merge

I think it might also be nice to have a full workflow in the example section that applys teSSS, together with head movement correction. Is there a dataset which would be used for that? Else we could record a small dataset for this purpose and upload it somewhere.

Okay, given the complexity of adding a new dataset, I guess it's easiest to link the tutorial.

Generally it would be great to have an improved MaxFilter tutorial that shows all the variants that SSS can have (with/without movement correction, move to default head position, move to average head position of other participants, tSSS, eSSS, etc etc), as some of the functionality is slightly underdocumented currently. But generally the information is there, it's just in different examples/tutorials/docstrings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More information on eSSS for MaxFilter algorithm

2 participants