-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add more information to eSSS in examples and docsstring #13591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
larsoner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor commits, I'll push and then merge when green, thanks @skjerns !
|
Oh I just saw draft and main comments, so I won't mark for merge
|
Added external example link for teSSS with movement compensation.
for more information, see https://pre-commit.ci
Okay, given the complexity of adding a new dataset, I guess it's easiest to link the tutorial. Generally it would be great to have an improved MaxFilter tutorial that shows all the variants that SSS can have (with/without movement correction, move to default head position, move to average head position of other participants, tSSS, eSSS, etc etc), as some of the functionality is slightly underdocumented currently. But generally the information is there, it's just in different examples/tutorials/docstrings |
fixes #13581
I've added some more information on eSSS and how to apply it. I'm far from an expert in SSS, so please let me know if my wording is correct.
Additional information
I think it might also be nice to have a full workflow in the
examplesection that applysteSSS, together with head movement correction. Is there a dataset which would be used for that? Else we could record a small dataset for this purpose and upload it somewhere.