ENH: Add support for plotting ICA source timecourses in Report.add_ica#13697
Open
Aniketsy wants to merge 4 commits intomne-tools:mainfrom
Open
ENH: Add support for plotting ICA source timecourses in Report.add_ica#13697Aniketsy wants to merge 4 commits intomne-tools:mainfrom
Aniketsy wants to merge 4 commits intomne-tools:mainfrom
Conversation
Aniketsy
requested review from
agramfort,
drammock and
larsoner
as code owners
Contributor
Author
|
@larsoner gentle ping, please review these changes when you have a chance. Thanks! |
larsoner
reviewed
Mar 9, 2026
| if plot_sources: | ||
| if inst is None: | ||
| warn( | ||
| "Cannot plot ICA sources because inst=None. " |
Member
There was a problem hiding this comment.
I think this should be an error rather than a warning. Easy enough for a user to pass False if inst is None
Contributor
Author
There was a problem hiding this comment.
yes, that make sense, I'll update
mne/report/report.py
Outdated
| :meth:`mne.preprocessing.ICA.plot_sources`. Requires ``inst`` | ||
| to be provided. Defaults to ``False``. | ||
| .. versionadded:: 1.9 |
Contributor
Author
There was a problem hiding this comment.
Ah sorry, I missed this, it should be 1.12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13265
This is the result after local testing. I followed the documentation referenced in the issue to implement the feature. Please let me know if any improvements are needed. Thanks!