Skip to content

Fix projection updates to use current slider time in interactive plot_topomap#13705

Open
Aniketsy wants to merge 1 commit intomne-tools:mainfrom
Aniketsy:fix-11790
Open

Fix projection updates to use current slider time in interactive plot_topomap#13705
Aniketsy wants to merge 1 commit intomne-tools:mainfrom
Aniketsy:fix-11790

Conversation

@Aniketsy
Copy link
Contributor

This PR fixes #11790 an issue where projection updates in interactive plot_topomap were not using the time selected by the slider.

Changes made

  • stored the current slider time index during interaction.
  • Used this stored time index when applying projections.
  • ensured merged channel information is preserved during redraw.
  • cleared stale contour state when projections are reapplied.
  • Re-enabled the slider interaction test in test_plot_topomap_basic.

@Aniketsy Aniketsy requested a review from drammock as a code owner February 28, 2026 09:23
@larsoner
Copy link
Member

larsoner commented Mar 2, 2026

@Aniketsy CIs complain about changelog update

Do you have a minimal code snippet that you've been testing with that you can copy-paste here so a reviewer can run on main to see the problem, but see it fixed on this PR? That's usually a good way to test locally during development and facilitate review

@Aniketsy
Copy link
Contributor Author

Aniketsy commented Mar 3, 2026

@larsoner thanks for the suggestion. I don’t currently have a minimal reproducible snippet prepared, but I can go through the changes again and share a snippet to help with the review. I’ll also keep this in mind for future PR's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: plot_topomap slider clicking in interactive mode

2 participants