Add tools script dependencies to dev dependency group

[dikshaa2909]

Fixes #13683

What does this implement/fix?

Adds packaging and tomlkit to the dev dependency group in pyproject.toml. These packages are imported by scripts in the /tools directory that run during CI, but were not explicitly listed as dev dependencies.

Both are now explicitly included in the dev dependency group to ensure CI environments have all required tools.

[tsbinns]

@dikshaa2909 Thanks for opening the PR. I think what was meant is to create a new development dependency group, i.e., something like tools, rather than adding to the existing dev dependency group. But as it was @drammock's suggestion, they would need to confirm.

The wording of the issue could perhaps have been more specific, but in our pyproject.toml, the dependency-groups groups are only used for development dependencies, so they are all "dev dependency groups".

[drammock]

I think what was meant is to create a new development dependency group, i.e., something like tools, rather than adding to the existing dev dependency group.

agreed. Furthermore this does not do what was suggested in #13490 (comment)

[dikshaa2909]

@drammock @tsbinns Thanks for the feedback! Just to confirm before I make changes - you'd like me to create a completely new dependency group called tools (separate from dev), correct?

Should the tools group also be included in the dev group via {include-group = "tools"}, or should it remain separate?

[drammock]

you'd like me to create a completely new dependency group called tools (separate from dev), correct?

yes

Should the tools group also be included in the dev group via {include-group = "tools"}

yes

Also, read the comment I linked above: there are other packages used in various scripts within tools/ that should also be added there. Off the top of my head: pygithub, git-py, and maybe requests? double-check the scripts to see if I missed any, and to make sure that I remembered the names of the packages correctly (e.g. I forget if there are hyphens, underscores, or neither).

[dikshaa2909]

Updated! Created a tools dependency group with all packages from /tools scripts (ast-comments, black, gitpython, PyGithub, requests, tomlkit). Included in dev group.

Please let me know if any changes are needed! @drammock @tsbinns

[tsbinns]

@dikshaa2909 The places where these packages were being manually installed should be removed/replaced with a call to install the tools group if not already available. These are scattered throughout files in the .github and tools dirs (maybe elsewhere too), so you're best bet might be to grep for them.